Bug 41279 - LayoutTests/canvas/philip/tests/security.drawImage.image.html Failed and skipped
Summary: LayoutTests/canvas/philip/tests/security.drawImage.image.html Failed and skipped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on: 42573 49317
Blocks:
  Show dependency tree / graph
 
Reported: 2010-06-28 06:47 PDT by Chang Shu
Modified: 2010-11-10 06:36 PST (History)
5 users (show)

See Also:

Attachments
fix patch (73.75 KB, patch)
2010-06-28 08:43 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch (73.19 KB, patch)
2010-06-28 09:14 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch (73.19 KB, patch)
2010-06-28 10:41 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch (88.96 KB, patch)
2010-07-19 08:44 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch (88.72 KB, patch)
2010-07-19 10:40 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch (73.15 KB, patch)
2010-07-19 11:39 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch 1 (75.50 KB, patch)
2010-07-19 12:15 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
fix patch 1 (75.64 KB, patch)
2010-07-19 12:51 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2010-06-28 06:47:20 PDT 
The following security related canvas tests fail to pass and are put in the skipped list.
LayoutTests/canvas/philip/tests/security.drawImage.image.html
LayoutTests/canvas/philip/tests/security.drawImage.canvas.html
Comment 1 Chang Shu 2010-06-28 08:43:40 PDT 
Created attachment 59900 [details]
fix patch
Comment 2 Chang Shu 2010-06-28 09:14:16 PDT 
Created attachment 59902 [details]
fix patch
Comment 3 Chang Shu 2010-06-28 10:41:48 PDT 
Created attachment 59911 [details]
fix patch
Comment 4 Chang Shu 2010-06-28 12:46:51 PDT 
The script failed to patch the patch file but it seems to be a false-alarm to me. I don't understand why it tries to remove 'LayoutTests/canvas'. The log is here:
fatal: not removing 'LayoutTests/canvas' recursively without -r
Failed to git rm --force --ignore-unmatch LayoutTests/canvas. at /home/webkit/WebKit-qt-ews/WebKitTools/Scripts/svn-apply line 451.
Comment 6 Chang Shu 2010-06-29 15:03:41 PDT 
Am I the only one who has this problem? Is there a work-around so I can have my patch reviewed? thanks!
Comment 7 Chang Shu 2010-07-19 08:44:43 PDT 
Created attachment 61959 [details]
fix patch
Comment 8 Chang Shu 2010-07-19 09:06:55 PDT 
The problem could be that in the patch, file tests.js has the wrong line-ending. I plan to commit a quick patch that does the following on this file:
svn propset svn:eol-style native tests.js
Does this sound ok?
Comment 9 Chang Shu 2010-07-19 10:40:49 PDT 
Created attachment 61968 [details]
fix patch
Comment 10 Chang Shu 2010-07-19 11:39:03 PDT 
Created attachment 61971 [details]
fix patch
Comment 11 Chang Shu 2010-07-19 12:15:42 PDT 
Created attachment 61976 [details]
fix patch 1
Comment 12 Chang Shu 2010-07-19 12:51:36 PDT 
Created attachment 61983 [details]
fix patch 1
Comment 13 Kenneth Rohde Christiansen 2010-07-19 13:12:32 PDT 
Darin, what do you think about this change?
Comment 14 Darin Adler 2010-07-19 14:19:04 PDT 
Comment on attachment 61983 [details]
fix patch 1

Seems OK to move these. But why are we skipping all these tests on all platforms?
Comment 15 Chang Shu 2010-07-20 06:36:45 PDT 
(In reply to comment #14)
> (From update of attachment 61983 [details])
> Seems OK to move these. But why are we skipping all these tests on all platforms?

This is the 1st part of the patch. I split it because I thought it could solve the problem that my patch failed to be applied (see all the pink buttons above). Actually, the complete patch is attached already. I can re-enable it and if you think it's good, I will commit it manually.
Comment 16 Chang Shu 2010-07-20 06:38:11 PDT 
The 5th patch has the complete code change.
Comment 17 Chang Shu 2010-07-20 10:33:22 PDT 
Comment on attachment 61968 [details]
fix patch

manually committed attachment 61968 [details]
webkit trunk r63752.