Bug 41266 - [Qt] dump bf history of child windows
Summary: [Qt] dump bf history of child windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-06-27 13:29 PDT by Robert Hogan
Modified: 2010-06-28 11:47 PDT (History)
0 users

See Also:


Attachments
Patch (4.02 KB, patch)
2010-06-27 13:33 PDT, Robert Hogan
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-06-27 13:29:47 PDT
Fixes http/tests/navigation/new-window-redirect-history.html
Comment 1 Robert Hogan 2010-06-27 13:33:30 PDT
Created attachment 59862 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-06-28 06:42:11 PDT
Comment on attachment 59862 [details]
Patch

WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:804
 +          if (m_controller->shouldDumpBackForwardList()) {


WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807
 +                fprintf(stdout, "%s", dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).toUtf8().constData());
indentation seems wrong here, please fix before committing

WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807
 +                fprintf(stdout, "%s", dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).toUtf8().constData());
I guess this would look less confusing, if you added the cast to a separate line.
Comment 3 Robert Hogan 2010-06-28 11:47:44 PDT
Committed r62020: <http://trac.webkit.org/changeset/62020>