RESOLVED FIXED41266
[Qt] dump bf history of child windows 
https://bugs.webkit.org/show_bug.cgi?id=41266
Summary [Qt] dump bf history of child windows
Robert Hogan
Reported 2010-06-27 13:29:47 PDT
Fixes http/tests/navigation/new-window-redirect-history.html
Attachments
Patch (4.02 KB, patch)
2010-06-27 13:33 PDT, Robert Hogan 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2010-06-27 13:33:30 PDT
Created attachment 59862 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2010-06-28 06:42:11 PDT
Comment on attachment 59862 [details] Patch WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:804 + if (m_controller->shouldDumpBackForwardList()) { WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807 + fprintf(stdout, "%s", dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).toUtf8().constData()); indentation seems wrong here, please fix before committing WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:807 + fprintf(stdout, "%s", dumpBackForwardList(qobject_cast<QWebPage*>(widget->findChild<QWebPage*>())).toUtf8().constData()); I guess this would look less confusing, if you added the cast to a separate line.
Robert Hogan
Comment 3 2010-06-28 11:47:44 PDT
Committed r62020: <http://trac.webkit.org/changeset/62020>
Note You need to log in before you can comment on or make changes to this bug.