Bug 41255 - Add more use of reflection, remove unused functions
Summary: Add more use of reflection, remove unused functions
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
Depends on:
Blocks: 41077
  Show dependency treegraph
Reported: 2010-06-26 11:47 PDT by Darin Adler
Modified: 2010-06-26 14:13 PDT (History)
4 users (show)

See Also:

Patch (87.89 KB, patch)
2010-06-26 12:32 PDT, Darin Adler
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2010-06-26 11:47:32 PDT
Add more use of reflection, remove unused functions
Comment 1 Darin Adler 2010-06-26 12:32:46 PDT
Created attachment 59843 [details]
Comment 2 WebKit Review Bot 2010-06-26 13:04:19 PDT
Attachment 59843 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3305742
Comment 3 WebKit Review Bot 2010-06-26 13:27:52 PDT
Attachment 59843 [details] did not build on win:
Build output: http://webkit-commit-queue.appspot.com/results/3321834
Comment 4 Darin Adler 2010-06-26 13:43:27 PDT
Committed r61959: <http://trac.webkit.org/changeset/61959>
Comment 5 WebKit Review Bot 2010-06-26 13:49:48 PDT
http://trac.webkit.org/changeset/61959 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release
Comment 6 Darin Adler 2010-06-26 13:52:20 PDT
http://trac.webkit.org/changeset/61960 fixes a stray character and should fix at least some platforms. Waiting to see if bots indicate any other breakage.
Comment 7 Darin Adler 2010-06-26 13:55:09 PDT
http://trac.webkit.org/changeset/61961 is an attempt to fix Qt by adding back a function it uses
Comment 8 Darin Adler 2010-06-26 14:13:49 PDT
http://trac.webkit.org/changeset/61963 is an attempt to fix Chromium by adding back functions it uses