Bug 41247 – Web Inspector: ScripsPanel.prototype.editScriptSource uses old addBreakpoint signature.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

I also added code preventing removed breakpoints from generating events.

[Pavel Feldman]

Created attachment 59829 [details]
[PATCH] Proposed fix.

[WebKit Review Bot]

Attachment 59829 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/inspector/front-end/Object.js:57:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Feldman]

Created attachment 59830 [details]
[PATCH] Style fixed.

[Yury Semikhatsky]

Comment on attachment 59830 [details]
[PATCH] Style fixed.

WebCore/inspector/front-end/BreakpointManager.js:151
 +              this._breakpointManager._saveBreakpointOnBackend(this);
These methods should not be called after the breakpoint has been removed. Can you fix the call sites instead?

We need a test for this.

[Pavel Feldman]

(In reply to comment #4)
> (From update of attachment 59830 [details])
> WebCore/inspector/front-end/BreakpointManager.js:151
>  +              this._breakpointManager._saveBreakpointOnBackend(this);
> These methods should not be called after the breakpoint has been removed. Can you fix the call sites instead?
> 

There are no call sites like this - I was just making sure we don't hit this problem in the future. But I see your point, I'll remove the checks and let code fail now that manager reference is cleared.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/BreakpointManager.js
	M	WebCore/inspector/front-end/Object.js
	M	WebCore/inspector/front-end/ScriptsPanel.js
Committed r61954