Bug 41242 – [chromium] Get the selected text from plugins for right click menu

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[John Abd-El-Malek]

[chromium] Get the selected text from plugins for right click menu

[John Abd-El-Malek]

Created attachment 59821 [details]
Patch

[WebKit Review Bot]

Attachment 59821 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/src/ContextMenuClientImpl.cpp:188:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebKit/chromium/src/WebPluginContainerImpl.cpp:249:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[John Abd-El-Malek]

Created attachment 59866 [details]
Patch

[John Abd-El-Malek]

Created attachment 59867 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 59867 [details]
Patch

WebKit/chromium/src/ContextMenuClientImpl.cpp:166
 +      // We can always select all...
nit: and translate

WebKit/chromium/src/ContextMenuClientImpl.cpp:219
 +          data.editFlags &= ~WebContextMenuData::CanTranslate;
maybe this should be inside the isWidget() block?  an object tag can
also be used like a DIV.

[John Abd-El-Malek]

(In reply to comment #5)
> (From update of attachment 59867 [details])
> WebKit/chromium/src/ContextMenuClientImpl.cpp:166
>  +      // We can always select all...
> nit: and translate

I didn't change this because for translate, it's not always possible per the code below it.
> 
> WebKit/chromium/src/ContextMenuClientImpl.cpp:219
>  +          data.editFlags &= ~WebContextMenuData::CanTranslate;
> maybe this should be inside the isWidget() block?  an object tag can
> also be used like a DIV.

done.  i'm not familiar with the differences between these two.  if it's a widget and it's an embed/object tag, are we guaranteed it's a plugin?

[Darin Fisher (:fishd, Google)]

> done.  i'm not familiar with the differences between these two.  if it's a widget and it's an embed/object tag, are we guaranteed it's a plugin?

yes.

[John Abd-El-Malek]

Created attachment 59919 [details]
Patch

[John Abd-El-Malek]

Committed r62036: <http://trac.webkit.org/changeset/62036>