[chromium] Get the selected text from plugins for right click menu
Created attachment 59821 [details]
Attachment 59821 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/src/ContextMenuClientImpl.cpp:188: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] 
WebKit/chromium/src/WebPluginContainerImpl.cpp:249: Place brace on its own line for function definitions. [whitespace/braces] 
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 59866 [details]
Created attachment 59867 [details]
Comment on attachment 59867 [details]
+ // We can always select all...
nit: and translate
+ data.editFlags &= ~WebContextMenuData::CanTranslate;
maybe this should be inside the isWidget() block? an object tag can
also be used like a DIV.
(In reply to comment #5)
> (From update of attachment 59867 [details])
> + // We can always select all...
> nit: and translate
I didn't change this because for translate, it's not always possible per the code below it.
> + data.editFlags &= ~WebContextMenuData::CanTranslate;
> maybe this should be inside the isWidget() block? an object tag can
> also be used like a DIV.
done. i'm not familiar with the differences between these two. if it's a widget and it's an embed/object tag, are we guaranteed it's a plugin?
> done. i'm not familiar with the differences between these two. if it's a widget and it's an embed/object tag, are we guaranteed it's a plugin?
Created attachment 59919 [details]
Committed r62036: <http://trac.webkit.org/changeset/62036>