Bug 41242 - [chromium] Get the selected text from plugins for right click menu
Summary: [chromium] Get the selected text from plugins for right click menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: John Abd-El-Malek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 18:21 PDT by John Abd-El-Malek
Modified: 2010-06-28 14:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.69 KB, patch)
2010-06-25 18:23 PDT, John Abd-El-Malek 		no flags Details | Formatted Diff | Diff
Patch (6.98 KB, patch)
2010-06-27 18:17 PDT, John Abd-El-Malek 		no flags Details | Formatted Diff | Diff
Patch (6.98 KB, patch)
2010-06-27 18:26 PDT, John Abd-El-Malek 		no flags Details | Formatted Diff | Diff
Patch (6.99 KB, patch)
2010-06-28 12:09 PDT, John Abd-El-Malek 		fishd: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2010-06-25 18:21:06 PDT 
[chromium] Get the selected text from plugins for right click menu
Comment 1 John Abd-El-Malek 2010-06-25 18:23:23 PDT 
Created attachment 59821 [details]
Patch
Comment 2 WebKit Review Bot 2010-06-25 18:26:14 PDT 
Attachment 59821 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/src/ContextMenuClientImpl.cpp:188:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebKit/chromium/src/WebPluginContainerImpl.cpp:249:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 John Abd-El-Malek 2010-06-27 18:17:10 PDT 
Created attachment 59866 [details]
Patch
Comment 4 John Abd-El-Malek 2010-06-27 18:26:29 PDT 
Created attachment 59867 [details]
Patch
Comment 5 Darin Fisher (:fishd, Google) 2010-06-28 10:29:28 PDT 
Comment on attachment 59867 [details]
Patch

WebKit/chromium/src/ContextMenuClientImpl.cpp:166
 +      // We can always select all...
nit: and translate

WebKit/chromium/src/ContextMenuClientImpl.cpp:219
 +          data.editFlags &= ~WebContextMenuData::CanTranslate;
maybe this should be inside the isWidget() block?  an object tag can
also be used like a DIV.
Comment 6 John Abd-El-Malek 2010-06-28 12:01:26 PDT 
(In reply to comment #5)
> (From update of attachment 59867 [details])
> WebKit/chromium/src/ContextMenuClientImpl.cpp:166
>  +      // We can always select all...
> nit: and translate

I didn't change this because for translate, it's not always possible per the code below it.
> 
> WebKit/chromium/src/ContextMenuClientImpl.cpp:219
>  +          data.editFlags &= ~WebContextMenuData::CanTranslate;
> maybe this should be inside the isWidget() block?  an object tag can
> also be used like a DIV.

done.  i'm not familiar with the differences between these two.  if it's a widget and it's an embed/object tag, are we guaranteed it's a plugin?
Comment 7 Darin Fisher (:fishd, Google) 2010-06-28 12:06:21 PDT 
> done.  i'm not familiar with the differences between these two.  if it's a widget and it's an embed/object tag, are we guaranteed it's a plugin?

yes.
Comment 8 John Abd-El-Malek 2010-06-28 12:09:18 PDT 
Created attachment 59919 [details]
Patch
Comment 9 John Abd-El-Malek 2010-06-28 14:07:26 PDT 
Committed r62036: <http://trac.webkit.org/changeset/62036>