Bug 41235 - uniformmatrix* should generate INVALID_VALUE with transpose = true
Summary: uniformmatrix* should generate INVALID_VALUE with transpose = true
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 16:52 PDT by Zhenyao Mo
Modified: 2010-06-29 15:22 PDT (History)
5 users (show)

See Also:

Attachments
patch (10.98 KB, patch)
2010-06-28 10:28 PDT, Zhenyao Mo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2010-06-25 16:52:36 PDT 
This is different between GL and GLES.
Comment 1 Zhenyao Mo 2010-06-28 10:28:59 PDT 
Created attachment 59908 [details]
patch
Comment 2 Kenneth Russell 2010-06-28 18:16:21 PDT 
Comment on attachment 59908 [details]
patch

Looks good. If there isn't already one, a bug should be filed about validating the size of the incoming Float32Arrays or (float*, int size) argument pairs. That validation should go pretty easily into the new validateUniformMatrixParameters helper.
Comment 3 Dimitri Glazkov (Google) 2010-06-29 14:58:28 PDT 
Comment on attachment 59908 [details]
patch

ok.
Comment 4 WebKit Commit Bot 2010-06-29 15:22:30 PDT 
Comment on attachment 59908 [details]
patch

Clearing flags on attachment: 59908

Committed r62150: <http://trac.webkit.org/changeset/62150>
Comment 5 WebKit Commit Bot 2010-06-29 15:22:35 PDT 
All reviewed patches have been landed.  Closing bug.