Bug 41216 – REGRESSION(r61812): breaks Chromium workers tests (Requested by mnaganov on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/61812 broke the build:
breaks Chromium workers tests (Requested by mnaganov on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 59772 [details]
ROLLOUT of r61812

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Mikhail Naganov]

Comment on attachment 59772 [details]
ROLLOUT of r61812

Clearing flags on attachment: 59772

Committed r61866: <http://trac.webkit.org/changeset/61866>

[Mikhail Naganov]

All reviewed patches have been landed.  Closing bug.

[Dumitru Daniliuc]

IMHO, there's no need to rollback a 65K WebKit patch because of a test that fails on Chromium only. DISABLE-ing it on the Chromium side (or adding it to test_expectations.txt) and opening a Chromium bug for it should be enough.

[Mikhail Naganov]

Yeah, sorry -- this is my first gardening. I consulted with Darin, he suggested to roll back. The tree was messy, I decided that this is a good decision. Next time I'll try your approach.