Bug 41212 - Chrome DevTools: Finalize migration to new WebView creation (devtools agent is now created within WebViewImpl only).
Summary: Chrome DevTools: Finalize migration to new WebView creation (devtools agent i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-25 06:39 PDT by Pavel Feldman
Modified: 2010-06-30 05:27 PDT (History)
3 users (show)

See Also:


Attachments
[PATCH] Proposed change. (5.67 KB, patch)
2010-06-25 08:16 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] Same with chromium fix. (6.66 KB, patch)
2010-06-26 04:59 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] Same with chromium fix (for try bots). (7.27 KB, patch)
2010-06-26 06:29 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATH] People keep adding usages... (7.79 KB, patch)
2010-06-26 08:24 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-06-25 06:39:28 PDT
Patch to follow.
Comment 1 Pavel Feldman 2010-06-25 08:16:50 PDT
Created attachment 59768 [details]
[PATCH] Proposed change.
Comment 2 WebKit Review Bot 2010-06-25 08:23:29 PDT
Attachment 59768 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3347025
Comment 3 Pavel Feldman 2010-06-26 04:59:45 PDT
Created attachment 59832 [details]
[PATCH] Same with chromium fix.
Comment 4 WebKit Review Bot 2010-06-26 06:11:35 PDT
Attachment 59832 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3340809
Comment 5 Pavel Feldman 2010-06-26 06:29:59 PDT
Created attachment 59834 [details]
[PATCH] Same with chromium fix (for try bots).
Comment 6 WebKit Review Bot 2010-06-26 07:22:47 PDT
Attachment 59834 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3336787
Comment 7 Pavel Feldman 2010-06-26 08:24:09 PDT
Created attachment 59836 [details]
[PATH] People keep adding usages...
Comment 8 Pavel Feldman 2010-06-26 22:51:37 PDT
Comment on attachment 59836 [details]
[PATH] People keep adding usages...

Ok, no more new usages, setting r+,cq+ for landing.
Comment 9 Pavel Feldman 2010-06-26 22:52:28 PDT
Comment on attachment 59836 [details]
[PATH] People keep adding usages...

Actually, since it may still break things upstream, I'll land manually.
Comment 10 Eric Seidel (no email) 2010-06-29 03:18:01 PDT
Comment on attachment 59832 [details]
[PATCH] Same with chromium fix.

Cleared Yury Semikhatsky's review+ from obsolete attachment 59832 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 11 Pavel Feldman 2010-06-30 05:27:48 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/public/WebDevToolsAgent.h
	M	WebKit/chromium/public/WebView.h
	M	WebKit/chromium/src/WebDevToolsAgentImpl.cpp
	M	WebKit/chromium/src/WebViewImpl.cpp
	M	WebKit/chromium/src/WebViewImpl.h
	M	WebKit/chromium/src/WebWorkerBase.cpp
	M	WebKit/chromium/src/js/DevToolsHostStub.js
	M	WebKit/chromium/tests/PopupMenuTest.cpp
	M	WebKitTools/DumpRenderTree/chromium/TestShell.cpp
Committed r62178