RESOLVED FIXED 41212
Chrome DevTools: Finalize migration to new WebView creation (devtools agent is now created within WebViewImpl only). 
https://bugs.webkit.org/show_bug.cgi?id=41212
Summary Chrome DevTools: Finalize migration to new WebView creation (devtools agent i...
Pavel Feldman
Reported 2010-06-25 06:39:28 PDT
Patch to follow.
Attachments
[PATCH] Proposed change. (5.67 KB, patch)
2010-06-25 08:16 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Same with chromium fix. (6.66 KB, patch)
2010-06-26 04:59 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATCH] Same with chromium fix (for try bots). (7.27 KB, patch)
2010-06-26 06:29 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[PATH] People keep adding usages... (7.79 KB, patch)
2010-06-26 08:24 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-06-25 08:16:50 PDT
Created attachment 59768 [details] [PATCH] Proposed change.
WebKit Review Bot
Comment 2 2010-06-25 08:23:29 PDT
Attachment 59768 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3347025
Pavel Feldman
Comment 3 2010-06-26 04:59:45 PDT
Created attachment 59832 [details] [PATCH] Same with chromium fix.
WebKit Review Bot
Comment 4 2010-06-26 06:11:35 PDT
Attachment 59832 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3340809
Pavel Feldman
Comment 5 2010-06-26 06:29:59 PDT
Created attachment 59834 [details] [PATCH] Same with chromium fix (for try bots).
WebKit Review Bot
Comment 6 2010-06-26 07:22:47 PDT
Attachment 59834 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3336787
Pavel Feldman
Comment 7 2010-06-26 08:24:09 PDT
Created attachment 59836 [details] [PATH] People keep adding usages...
Pavel Feldman
Comment 8 2010-06-26 22:51:37 PDT
Comment on attachment 59836 [details] [PATH] People keep adding usages... Ok, no more new usages, setting r+,cq+ for landing.
Pavel Feldman
Comment 9 2010-06-26 22:52:28 PDT
Comment on attachment 59836 [details] [PATH] People keep adding usages... Actually, since it may still break things upstream, I'll land manually.
Eric Seidel (no email)
Comment 10 2010-06-29 03:18:01 PDT
Comment on attachment 59832 [details] [PATCH] Same with chromium fix. Cleared Yury Semikhatsky's review+ from obsolete attachment 59832 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Pavel Feldman
Comment 11 2010-06-30 05:27:48 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebDevToolsAgent.h M WebKit/chromium/public/WebView.h M WebKit/chromium/src/WebDevToolsAgentImpl.cpp M WebKit/chromium/src/WebViewImpl.cpp M WebKit/chromium/src/WebViewImpl.h M WebKit/chromium/src/WebWorkerBase.cpp M WebKit/chromium/src/js/DevToolsHostStub.js M WebKit/chromium/tests/PopupMenuTest.cpp M WebKitTools/DumpRenderTree/chromium/TestShell.cpp Committed r62178
Note You need to log in before you can comment on or make changes to this bug.