Bug 41209 – Fill mode is broken with multiple keyframes

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dean Jackson]

Created attachment 59759 [details]
test case

I'm ashamed that this got past my testing.

Forward fill modes are broken when there is more than one keyframe. I've attached an updated regression test which shows the problem.

[Dean Jackson]

<rdar://problem/8035746>

[Dean Jackson]

Created attachment 67021 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 67021 [details]
Patch

Can the tests use animation-test-helpers.js? If the pause stuff doesn't work with fill modes, we should fix it.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog

> [phone]  Dean Jackson  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fill mode is broken with multiple keyframes
> +        https://bugs.webkit.org/show_bug.cgi?id=41209
> +

This needs to say what the problem was, and how you fixed it.

r=me, but it would be nice of the tests could be more cookie-cutter, and make use of the pause API so they run faster.

[Dean Jackson]

The tests can't use the API because they don't test values during the run. They are testing values before and after. They are all event based rather than timeouts - so it should be ok.

[Dean Jackson]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/animations/fill-mode-missing-from-to-keyframes-expected.txt
	A	LayoutTests/animations/fill-mode-missing-from-to-keyframes.html
	A	LayoutTests/animations/fill-mode-multiple-keyframes-expected.txt
	A	LayoutTests/animations/fill-mode-multiple-keyframes.html
	M	WebCore/ChangeLog
	M	WebCore/page/animation/KeyframeAnimation.cpp
Committed r67098