Bug 41204 - Split up isSVGText() in isSVGText() / isSVGInlineText()
Summary: Split up isSVGText() in isSVGText() / isSVGInlineText()
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on:
Reported: 2010-06-25 02:43 PDT by Nikolas Zimmermann
Modified: 2010-06-25 03:59 PDT (History)
3 users (show)

See Also:

Initial patch (4.98 KB, patch)
2010-06-25 02:45 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Updated patch (4.86 KB, patch)
2010-06-25 02:54 PDT, Nikolas Zimmermann
rwlbuis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-06-25 02:43:09 PDT
We're currently using a dangerous way to differentiate between RenderSVGText / RenderSVGInlineText. We should better introduce a seperated isSVGInlineText(), to avoid confusion, and to be consistent with all other isFoo() functions.
(isFoo() means can be casted to RenderFoo, everywhere else)
Comment 1 Nikolas Zimmermann 2010-06-25 02:45:13 PDT
Created attachment 59748 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2010-06-25 02:54:40 PDT
Created attachment 59750 [details]
Updated patch

Uploaded the wrong patch :( The second one is correct.
Comment 3 Nikolas Zimmermann 2010-06-25 03:05:03 PDT
Landed in r61844.
Comment 4 WebKit Review Bot 2010-06-25 03:59:53 PDT
http://trac.webkit.org/changeset/61844 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list: