Bug 41202 - Move decoding into DocumentParser to further simplify RawDataDocumentParser and DocumentWriter
Summary: Move decoding into DocumentParser to further simplify RawDataDocumentParser a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 41197
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-25 02:25 PDT by Eric Seidel (no email)
Modified: 2010-06-25 16:47 PDT (History)
2 users (show)

See Also:


Attachments
work in progress (18.77 KB, patch)
2010-06-25 02:29 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
work in progress (23.92 KB, patch)
2010-06-25 02:39 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (23.87 KB, patch)
2010-06-25 14:47 PDT, Eric Seidel (no email)
abarth: review+
abarth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-25 02:25:24 PDT
Move decoding into DocumentParser to further simplify RawDataDocumentParser and DocumentWriter
Comment 1 Eric Seidel (no email) 2010-06-25 02:29:03 PDT
Created attachment 59746 [details]
work in progress
Comment 2 Eric Seidel (no email) 2010-06-25 02:39:50 PDT
Created attachment 59747 [details]
work in progress
Comment 3 Eric Seidel (no email) 2010-06-25 14:47:19 PDT
Created attachment 59799 [details]
Patch
Comment 4 Adam Barth 2010-06-25 15:10:25 PDT
Comment on attachment 59799 [details]
Patch

It's slightly wonky that the raw data folks have a document writer that they ignore, but I guess that makes sense...

We need a better name that DocumentWriter...
Comment 5 Eric Seidel (no email) 2010-06-25 15:13:48 PDT
I think the RawData folks are wrongly designed.  They don't want to be parsers.  They want some earlier method they can override to not be a parser.  The RawData class is all about just sharing the broken code, not because it's the right design long-term.  Shared broken code is better than copy/pasted broken code. :)
Comment 6 Eric Seidel (no email) 2010-06-25 16:47:19 PDT
Committed r61916: <http://trac.webkit.org/changeset/61916>