CanvasRenderingContext2D's bezierCurveTo() and quadraticCurveTo() should implicitly moveTo() the (first) control point if the current path is empty. This test (on IE Test Center) fails: http://samples.msdn.microsoft.com/ietestcenter/html5/canvas/canvas-complexShapes-bezierCurveTo-001.htm This is also covered by (skipped) in-tree tests: canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2.html canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2.html Spec links: http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-beziercurveto http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-quadraticcurveto
Created attachment 59733 [details] Proposed patch
Created attachment 59734 [details] Proposed patch The proposed patch for *this* bug ;-)
Attachment 59734 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/canvas/CanvasRenderingContext2D.cpp:579: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 59735 [details] Proposed patch v2 (style fixed)
Comment on attachment 59735 [details] Proposed patch v2 (style fixed) LGTM
Comment on attachment 59735 [details] Proposed patch v2 (style fixed) Rejecting patch 59735 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: ng Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19263 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14177 tests run. 261.24s total testing time 14176 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 4 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3372119
Comment on attachment 59735 [details] Proposed patch v2 (style fixed) Re-cq?ing, suspecting flaky test.
Comment on attachment 59735 [details] Proposed patch v2 (style fixed) Let's try again
Comment on attachment 59735 [details] Proposed patch v2 (style fixed) Clearing flags on attachment: 59735 Committed r62300: <http://trac.webkit.org/changeset/62300>
All reviewed patches have been landed. Closing bug.