Bug 41180 - Fix NewRunWebKitTests to work on Windows.
Summary: Fix NewRunWebKitTests to work on Windows.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Windows XP
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-24 15:25 PDT by Dimitri Glazkov (Google)
Modified: 2010-07-19 08:25 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2010-06-24 15:27 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Patch 2 (1.39 KB, patch)
2010-06-29 01:45 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2010-06-24 15:25:46 PDT
Fix NewRunWebKitTests to work on Windows.
Comment 1 Dimitri Glazkov (Google) 2010-06-24 15:27:20 PDT
Created attachment 59705 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-24 15:29:38 PDT
Comment on attachment 59705 [details]
Patch

I think we should just remove this bot.  My plans for world domination no longer require it. :)
Comment 3 Dimitri Glazkov (Google) 2010-06-24 15:31:21 PDT
(In reply to comment #2)
> (From update of attachment 59705 [details])
> I think we should just remove this bot.  My plans for world domination no longer require it. :)

Your plans are obsolete. We're now running three bots using this step :)
Comment 4 Dimitri Glazkov (Google) 2010-06-24 15:32:08 PDT
Committed r61792: <http://trac.webkit.org/changeset/61792>
Comment 5 William Siegrist 2010-06-24 15:42:57 PDT
Master updated. Restart process is waiting for the bots to quiesce.
Comment 6 Kent Tamura 2010-06-29 01:42:21 PDT
Unfortunately, this change didn't work.

> Can't exec /usr/bin/env at ./WebKitTools/Scripts/new-run-webkit-tests line 1.

Probably we should use python instead of perl :-)
Comment 7 Kent Tamura 2010-06-29 01:45:07 PDT
Created attachment 59996 [details]
Patch 2
Comment 8 Adam Roben (:aroben) 2010-07-19 07:54:53 PDT
Comment on attachment 59996 [details]
Patch 2

r=me
Comment 9 Kent Tamura 2010-07-19 08:12:14 PDT
Comment on attachment 59996 [details]
Patch 2

Clearing flags on attachment: 59996

Committed r63661: <http://trac.webkit.org/changeset/63661>
Comment 10 Kent Tamura 2010-07-19 08:12:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 William Siegrist 2010-07-19 08:25:41 PDT
Master updated. Restart process is waiting for the bots to quiesce.