Need ability to get rendered rectangle.

[Damian Kaleta]

Need ability to get rendered rectangle.

[Damian Kaleta]

Created attachment 59666 [details]
propose patch

[Sam Weinig]

Comment on attachment 59666 [details]
propose patch

>  
>  @interface DOMNode (WebDOMNodeOperationsPendingPublic)
> -- (NSString *)markupString;
> +- (CGRect)_renderRect:(bool *)isReplaced;

We should not remove markupString in this patch. If we want to do it it should be done in a subsequent patch.

> +@implementation DOMNode (WebDOMNodeOperationsPendingPublic)
> +
> +- (CGRect)_renderRect:(bool *)isReplaced
> +{
> +    return CGRect(core(self)->renderRect(isReplaced));

This should return a NSRect instead of a CGRect since this is an Objective-C API.

> +IntRect Node::renderRect(bool* isReplaced)
> +{
> +    IntRect rect(0, 0, 0, 0);
> +    
> +    RenderObject* hitRenderer = this->renderer();
> +    ASSERT(hitRenderer);
> +    RenderObject* renderer = hitRenderer;
> +    while (renderer && !renderer->isBody() && !renderer->isRoot()) {
> +        if (renderer->isRenderBlock() || renderer->isInlineBlockOrInlineTable() || renderer->isReplaced()) {
> +            *isReplaced = renderer->isReplaced();
> +            return renderer->absoluteBoundingBoxRect(true);
> +        }
> +        renderer = renderer->parent();
> +    }
> +    return rect;

This should just be return IntRect(). You can remove the rect declaration at the top.

r-. Lets iterate on this.

[Damian Kaleta]

Created attachment 59677 [details]
propose patch