After selecting some text in a non-editable area, it should be possible to change the selection by holding down the shift key and arrow keys. This doesn't work in the GTK+ port.
Created attachment 59679 [details] Fix for this issue
Comment on attachment 59679 [details] Fix for this issue So we are changing the logic a bit here, before we were allowing all kinds of events if caret mode was enabled. Are you changing that on purpose?
Yes. Before we were only allowing editor commands: 1. If the node was editable. 2. If caret browsing was enabled. This patch enables editor commands: 1. If the commands don't insert text (includes all caret browsing commands, AFAIK). 2. The command inserts text and the node is editable. I think this new logic is more precise. The only change that I can see is that previously a caret browsing command that inserted text (if such a beast existed) could operate on a non-editable node. I think disallowing that is a better behavior here.
(In reply to comment #3) > Yes. Before we were only allowing editor commands: > > 1. If the node was editable. > 2. If caret browsing was enabled. > > This patch enables editor commands: > > 1. If the commands don't insert text (includes all caret browsing commands, AFAIK). > 2. The command inserts text and the node is editable. > > I think this new logic is more precise. The only change that I can see is that previously a caret browsing command that inserted text (if such a beast existed) could operate on a non-editable node. I think disallowing that is a better behavior here. Right, this is how I understood the patch but wanted to double-check it was intentional. I don't think there's such a thing as a text inserting caret command, no :)
Comment on attachment 59679 [details] Fix for this issue r=me
Comment on attachment 59679 [details] Fix for this issue Clearing flags on attachment: 59679 Committed r61808: <http://trac.webkit.org/changeset/61808>
All reviewed patches have been landed. Closing bug.