Bug 41152 – Minor fixes to Mac FontPlatformData & SimpleFontPlatformData classes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jeremy Moskovich]

Bug to track a few very minor fixes to the Mac FontPlatformData & SimpleFontPlatformData classes .

[Jeremy Moskovich]

Created attachment 59644 [details]
patch 1

* Avoid an extra FontPlatformData copy in SimpleFontDataMac.mm
* Fix a typo in a comment in FontPlatformDataMac.mm
* Change ' *' -> '* ' to match style guide

Comment on attachment 59644 [details]
patch 1

While the WebKit Coding Style Guidelines only say “Pointer types in non-C++ code — Pointer types should be written with a space between the type and the * (so the * is adjacent to the following identifier if any)”, WebKit style is for Objective-C types to always have a space between the type and the *, whether they appear in C, C++, Objective-C or Objective-C++ code, and most of the code adheres to this style.

[Jeremy Moskovich]

Created attachment 59663 [details]
patch 2

[Alexey Proskuryakov]

Comment on attachment 59663 [details]
patch 2

+        * Fix a typo in a comment in FontPlatformDataMac.mm

The actual fix isn't in a comment. Please fix before loading.

[Alexey Proskuryakov]

before landing

[Jeremy Moskovich]

Created attachment 60115 [details]
patch 3

Changelog fixed up.

[WebKit Commit Bot]

Comment on attachment 60115 [details]
patch 3

Rejecting patch 60115 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 60115, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
cgi?id=60115&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=41152&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 60115 from bug 41152.
NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Jeremy Moskovich]

Created attachment 60119 [details]
patch 4

[WebKit Commit Bot]

Comment on attachment 60119 [details]
patch 4

Clearing flags on attachment: 60119

Committed r62186: <http://trac.webkit.org/changeset/62186>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.