Bug 41145 - Add plugin accessors to WebPluginContainer.
Summary: Add plugin accessors to WebPluginContainer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-24 04:12 PDT by Bernhard Bauer
Modified: 2010-06-25 22:51 PDT (History)
2 users (show)

See Also:

Attachments
Add plugin accessor to WebPluginContainer. (1.73 KB, patch)
2010-06-24 04:16 PDT, Bernhard Bauer 		no flags Details | Formatted Diff | Diff
Add plugin accessor to WebPluginContainer. (1.72 KB, patch)
2010-06-24 10:20 PDT, Bernhard Bauer 		fishd: review-
Details | Formatted Diff | Diff
Add plugin accessor to WebPluginContainer. (2.27 KB, patch)
2010-06-25 04:41 PDT, Bernhard Bauer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Bauer 2010-06-24 04:12:23 PDT 
In order to swap out a plugin placeholder for a real plugin when doing click-to-load, WebPluginContainer needs accessors.
Comment 1 Bernhard Bauer 2010-06-24 04:16:47 PDT 
Created attachment 59630 [details]
Add plugin accessor to WebPluginContainer.
Comment 2 David Levin 2010-06-24 10:10:48 PDT 
Comment on attachment 59630 [details]
Add plugin accessor to WebPluginContainer.

fyi

WebKit/chromium/public/WebPluginContainer.h:82
 +      virtual void setPlugin(WebPlugin* plugin) = 0;
WebKit typically doesn't include parameter names in declarations when those names add no new information, so omit "plugin".
Comment 3 Bernhard Bauer 2010-06-24 10:20:58 PDT 
Created attachment 59668 [details]
Add plugin accessor to WebPluginContainer.

Removed parameter "plugin" from setPlugin().
Comment 4 Darin Fisher (:fishd, Google) 2010-06-24 11:16:01 PDT 
Comment on attachment 59668 [details]
Add plugin accessor to WebPluginContainer.



WebKit/chromium/src/WebPluginContainerImpl.h:111
 +      void setPlugin(WebPlugin* plugin) { m_webPlugin = plugin; }
nit: please move these into the "WebPluginContainer methods" section.
Comment 5 Bernhard Bauer 2010-06-25 04:41:29 PDT 
Created attachment 59758 [details]
Add plugin accessor to WebPluginContainer.

Moved accessors to WebPluginContainer methods section.
Comment 6 WebKit Commit Bot 2010-06-25 22:51:12 PDT 
Comment on attachment 59758 [details]
Add plugin accessor to WebPluginContainer.

Clearing flags on attachment: 59758

Committed r61942: <http://trac.webkit.org/changeset/61942>
Comment 7 WebKit Commit Bot 2010-06-25 22:51:17 PDT 
All reviewed patches have been landed.  Closing bug.