Bug 41140 - SVG polygons should draw polygons up to the first parsing error
Summary: SVG polygons should draw polygons up to the first parsing error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-24 02:22 PDT by Dirk Schulze
Modified: 2010-07-05 05:08 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.61 KB, patch)
2010-07-04 23:57 PDT, Rob Buis
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2010-06-24 02:22:40 PDT
SVG polygons should draw polygons upt to first parsing error. This is quite easy to fix. Just remove the line http://trac.webkit.org/browser/trunk/WebCore/svg/SVGPolyElement.cpp#L71 and the braces arround the if.
This needs a simple layouttest. I suggest to use http://samples.msdn.microsoft.com/ietestcenter/svg112/svg_harness.htm?url=./svg112/svg/chapter_09.8.svg and ask for the SVGPointListItems.
Don't have a mac arround atm, so I can't check if other tests need an update. If someone want's to beat me with a patch, I'm happy to review the fix. :-)
Comment 1 Rob Buis 2010-07-04 23:57:37 PDT
Created attachment 60498 [details]
Patch
Comment 2 Dirk Schulze 2010-07-05 01:56:57 PDT
Comment on attachment 60498 [details]
Patch

Great fix! ;-) r=me
Comment 3 Rob Buis 2010-07-05 05:07:44 PDT
Landed in r62478.