Bug 41136 - Add RawDataDocumentParser to get rid of a bunch of copy/paste code in DocumentParser subclasses
Summary: Add RawDataDocumentParser to get rid of a bunch of copy/paste code in Documen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 41117
Blocks: 41141
  Show dependency treegraph
 
Reported: 2010-06-24 00:35 PDT by Eric Seidel (no email)
Modified: 2010-06-24 15:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (19.55 KB, patch)
2010-06-24 00:42 PDT, Eric Seidel (no email)
abarth: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-24 00:35:34 PDT
Add RawDataDocumentParser to get rid of a bunch of copy/paste code in DocumentParser subclasses
Comment 1 Eric Seidel (no email) 2010-06-24 00:42:46 PDT
Created attachment 59622 [details]
Patch
Comment 2 Adam Barth 2010-06-24 14:43:38 PDT
Comment on attachment 59622 [details]
Patch

This patch appears to be almost entirely minus lines.

WebCore/dom/RawDataDocumentParser.h:57
 +          ASSERT_NOT_REACHED();
This used to be notImplemented, right?
Comment 3 Eric Seidel (no email) 2010-06-24 14:45:55 PDT
(In reply to comment #2)
> (From update of attachment 59622 [details])
> This patch appears to be almost entirely minus lines.

Yup. :)

> WebCore/dom/RawDataDocumentParser.h:57
>  +          ASSERT_NOT_REACHED();
> This used to be notImplemented, right?

Yup.  And remove the method entirely in the next patch.  We have no test case which hits that ASSERT, and its unclear if such a case is even possible.
Comment 4 Eric Seidel (no email) 2010-06-24 15:03:47 PDT
Committed r61789: <http://trac.webkit.org/changeset/61789>