Bug 41119 - Code generator now generates jsString instead of toJS for callbacks
Summary: Code generator now generates jsString instead of toJS for callbacks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 39905
  Show dependency treegraph
 
Reported: 2010-06-23 18:04 PDT by Sterling Swigart
Modified: 2010-06-25 20:40 PDT (History)
3 users (show)

See Also:


Attachments
toJS -> jsString (1.46 KB, patch)
2010-06-23 18:04 PDT, Sterling Swigart
no flags Details | Formatted Diff | Diff
Fixes callback parameter generation (2.27 KB, patch)
2010-06-24 10:35 PDT, Sterling Swigart
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sterling Swigart 2010-06-23 18:04:34 PDT
Created attachment 59591 [details]
toJS -> jsString

Callback code generation before generated toJS for String parameters, which cannot convert a String to DOMString. The generated file would not build.
Comment 1 Dumitru Daniliuc 2010-06-23 18:12:05 PDT
Comment on attachment 59591 [details]
toJS -> jsString

LGTM, thanks for noticing the bug and fixing it! Will cq+ once all bots go green.
Comment 2 Sterling Swigart 2010-06-24 10:35:28 PDT
Created attachment 59672 [details]
Fixes callback parameter generation
Comment 3 WebKit Commit Bot 2010-06-25 20:40:19 PDT
Comment on attachment 59672 [details]
Fixes callback parameter generation

Clearing flags on attachment: 59672

Committed r61937: <http://trac.webkit.org/changeset/61937>
Comment 4 WebKit Commit Bot 2010-06-25 20:40:23 PDT
All reviewed patches have been landed.  Closing bug.