Created attachment 59588 [details] ENABLE_IMAGE_RESIZER=0 Someone mistakenly set this value to 1 in features.gypi, but the feature is still under development.
Comment on attachment 59588 [details] ENABLE_IMAGE_RESIZER=0 Sorry this needs a changelog. r- for that. Typically Chromium has defines set to 1 even when the feature is under development (at least at a certain point), but at this stage I agree that it would be good for this feature to not be compiled into chromium.
I enabled it in http://trac.webkit.org/changeset/61547 because - it's good to check build by buidbot. - We'd like to minimize features.gypi change as possible. A change for features.gypi needs manual operation on Chromium buildbots for webkit.org. It's ok to reset it to 0 if it's hard to develop the feature with ENABLE_IMAGE_RESIZER=1.
(In reply to comment #2) > I enabled it in http://trac.webkit.org/changeset/61547 because > - it's good to check build by buidbot. > - We'd like to minimize features.gypi change as possible. > A change for features.gypi needs manual operation on Chromium buildbots for webkit.org. > > It's ok to reset it to 0 if it's hard to develop the feature with ENABLE_IMAGE_RESIZER=1. manual operation == dglazkov going to the hallway and mucking with computers made in previous century.
Created attachment 59669 [details] ENABLE_IMAGE_RESIZER=0
If we're going to enable it soon, can we spare my knees from doing this?
Comment on attachment 59669 [details] ENABLE_IMAGE_RESIZER=0 Clearing flags on attachment: 59669 Committed r61936: <http://trac.webkit.org/changeset/61936>
All reviewed patches have been landed. Closing bug.