Bug 41110 – Move more form submission logic into FormSubmission.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dimitri Glazkov (Google)]

Move more form submission logic into FormSubmission.

[Dimitri Glazkov (Google)]

Created attachment 59575 [details]
Patch

[Dimitri Glazkov (Google)]

Apologies for a largish patch -- I tried splitting it up, but the it was less readable in chunks.

[Eric Seidel (no email)]

Attachment 59575 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3331655

[WebKit Review Bot]

Attachment 59575 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3313637

[Dimitri Glazkov (Google)]

(In reply to comment #3)
> Attachment 59575 [details] did not build on mac:
> Build output: http://webkit-commit-queue.appspot.com/results/3331655

Weird... I don't get this error when building locally. I'll investigate.

[Dimitri Glazkov (Google)]

Created attachment 59670 [details]
Patch

[Dimitri Glazkov (Google)]

(In reply to comment #6)
> Created an attachment (id=59670) [details]
> Patch

I went back and forth on making FormSubmission::Attributes nested. It just looks prettier that way :)

[Kent Tamura]

Comment on attachment 59670 [details]
Patch

WebCore/loader/FormSubmission.h:56
 +              {
Indentation is wrong.  It should be 8 spaces.

[Dimitri Glazkov (Google)]

Fixed up and landed as http://trac.webkit.org/changeset/63999