RESOLVED FIXED Bug 41106
[chromium] Allow composited layers to own their textures and specify how they get rendered 
https://bugs.webkit.org/show_bug.cgi?id=41106
Summary [chromium] Allow composited layers to own their textures and specify how they...
Vangelis Kokkevis
Reported 2010-06-23 14:52:33 PDT
This is in preparation for hooking up WebGL with the compositor. The current code is too inflexible and makes adding new layer types that need special handling difficult.
Attachments
Proposed patch (43.05 KB, patch)
2010-06-23 15:54 PDT, Vangelis Kokkevis 		fishd: review-
DetailsFormatted DiffDiff
Proposed patch addressing review comments (58.75 KB, patch)
2010-06-23 18:04 PDT, Vangelis Kokkevis 		fishd: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vangelis Kokkevis
Comment 1 2010-06-23 15:54:23 PDT
Created attachment 59570 [details] Proposed patch
Darin Fisher (:fishd, Google)
Comment 2 2010-06-23 16:24:51 PDT
Comment on attachment 59570 [details] Proposed patch Looks good to me. Just a couple nits: WebCore/platform/graphics/chromium/LayerChromium.cpp:399 + unsigned int WebGLLayerChromium::m_shaderProgramId = 0; nit: webkit style is to just use "unsigned" instead of "unsigned int" WebCore/platform/graphics/chromium/LayerChromium.h:257 + class ImageLayerChromium : public LayerChromium { style-nit: one class per file is the rule. would you be okay splitting these out into their own files?
Vangelis Kokkevis
Comment 3 2010-06-23 18:04:50 PDT
Created attachment 59593 [details] Proposed patch addressing review comments
Vangelis Kokkevis
Comment 4 2010-06-23 18:05:41 PDT
(In reply to comment #2) > (From update of attachment 59570 [details]) > Looks good to me. Just a couple nits: > > WebCore/platform/graphics/chromium/LayerChromium.cpp:399 > + unsigned int WebGLLayerChromium::m_shaderProgramId = 0; > nit: webkit style is to just use "unsigned" instead of "unsigned int" Done. Also fixed all other instances of unsigned in the layer code. > > WebCore/platform/graphics/chromium/LayerChromium.h:257 > + class ImageLayerChromium : public LayerChromium { > style-nit: one class per file is the rule. would you be okay splitting > these out into their own files? Done.
Darin Fisher (:fishd, Google)
Comment 5 2010-06-24 11:11:25 PDT
Landed as http://trac.webkit.org/changeset/61775
Note You need to log in before you can comment on or make changes to this bug.