This is in preparation for hooking up WebGL with the compositor. The current code is too inflexible and makes adding new layer types that need special handling difficult.
Created attachment 59570 [details] Proposed patch
Comment on attachment 59570 [details] Proposed patch Looks good to me. Just a couple nits: WebCore/platform/graphics/chromium/LayerChromium.cpp:399 + unsigned int WebGLLayerChromium::m_shaderProgramId = 0; nit: webkit style is to just use "unsigned" instead of "unsigned int" WebCore/platform/graphics/chromium/LayerChromium.h:257 + class ImageLayerChromium : public LayerChromium { style-nit: one class per file is the rule. would you be okay splitting these out into their own files?
Created attachment 59593 [details] Proposed patch addressing review comments
(In reply to comment #2) > (From update of attachment 59570 [details]) > Looks good to me. Just a couple nits: > > WebCore/platform/graphics/chromium/LayerChromium.cpp:399 > + unsigned int WebGLLayerChromium::m_shaderProgramId = 0; > nit: webkit style is to just use "unsigned" instead of "unsigned int" Done. Also fixed all other instances of unsigned in the layer code. > > WebCore/platform/graphics/chromium/LayerChromium.h:257 > + class ImageLayerChromium : public LayerChromium { > style-nit: one class per file is the rule. would you be okay splitting > these out into their own files? Done.
Landed as http://trac.webkit.org/changeset/61775