Bug 41100 - add ENABLE_DIRECTORY_UPLOAD build support
Summary: add ENABLE_DIRECTORY_UPLOAD build support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: John Gregg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-23 13:53 PDT by John Gregg
Modified: 2010-06-28 16:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch (24.09 KB, patch)
2010-06-23 14:11 PDT, John Gregg
no flags Details | Formatted Diff | Diff
Patch (24.09 KB, patch)
2010-06-25 10:20 PDT, John Gregg
tkent: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Gregg 2010-06-23 13:53:12 PDT
new code for directory upload (see https://bugs.webkit.org/show_bug.cgi?id=40872) is behind ENABLE_DIRECTORY_UPLOAD flag; need to add the necessary build support.
Comment 1 John Gregg 2010-06-23 14:11:29 PDT
Created attachment 59561 [details]
Patch
Comment 2 WebKit Review Bot 2010-06-23 18:38:08 PDT
Attachment 59561 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3330642
Comment 3 Kent Tamura 2010-06-24 20:20:50 PDT
Comment on attachment 59561 [details]
Patch


> checking whether to build gtk-doc documentation... no
> checking for gtkdoc-check... /usr/bin/gtkdoc-check
> ../../configure: line 21510: syntax error near unexpected token `('
> ../../configure: line 21510: `    as_echo_body='eval expr "X$1" : "X\\(.*\\)"''
> Failed to setup build environment using 'autotools'!

I don't know the reason, but I confirmed this error of GTK was caused by your changes for config.ac and WebCore/GNUmakefile.am.

WebKit/chromium/features.gypi:48
 +          'ENABLE_DIRECTORY_UPLOAD=0',
I recommend enable ENABLE_DIRECTORY_UPLOAD for this file because
 - We can confirm build by buildbots
 - Changing features.gypi later is hard because of Bug#38926.
Comment 4 John Gregg 2010-06-25 10:20:00 PDT
Created attachment 59778 [details]
Patch
Comment 5 John Gregg 2010-06-25 10:20:46 PDT
(In reply to comment #3)
> (From update of attachment 59561 [details])
> 
> > checking whether to build gtk-doc documentation... no
> > checking for gtkdoc-check... /usr/bin/gtkdoc-check
> > ../../configure: line 21510: syntax error near unexpected token `('
> > ../../configure: line 21510: `    as_echo_body='eval expr "X$1" : "X\\(.*\\)"''
> > Failed to setup build environment using 'autotools'!
> 
> I don't know the reason, but I confirmed this error of GTK was caused by your changes for config.ac and WebCore/GNUmakefile.am.
> 

I think I found the typo (missing ").  Uploaded a new patch.

> WebKit/chromium/features.gypi:48
>  +          'ENABLE_DIRECTORY_UPLOAD=0',
> I recommend enable ENABLE_DIRECTORY_UPLOAD for this file because
>  - We can confirm build by buildbots
>  - Changing features.gypi later is hard because of Bug#38926.

Done.
Comment 6 Kent Tamura 2010-06-26 05:37:23 PDT
Comment on attachment 59778 [details]
Patch

OK
Comment 7 WebKit Commit Bot 2010-06-27 09:12:56 PDT
Comment on attachment 59778 [details]
Patch

Rejecting patch 59778 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1
Last 500 characters of output:
le WebKitLibraries/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
Hunk #1 FAILED at 9.
1 out of 2 hunks FAILED -- saving rejects to file WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops.rej
patching file WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/Scripts/build-webkit
Hunk #1 succeeded at 61 with fuzz 2.

Full output: http://webkit-commit-queue.appspot.com/results/3281909
Comment 8 John Gregg 2010-06-28 16:54:32 PDT
Committed r62049: <http://trac.webkit.org/changeset/62049>