Bug 41100 – add ENABLE_DIRECTORY_UPLOAD build support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[John Gregg]

new code for directory upload (see https://bugs.webkit.org/show_bug.cgi?id=40872) is behind ENABLE_DIRECTORY_UPLOAD flag; need to add the necessary build support.

[John Gregg]

Created attachment 59561 [details]
Patch

[WebKit Review Bot]

Attachment 59561 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3330642

[Kent Tamura]

Comment on attachment 59561 [details]
Patch


> checking whether to build gtk-doc documentation... no
> checking for gtkdoc-check... /usr/bin/gtkdoc-check
> ../../configure: line 21510: syntax error near unexpected token `('
> ../../configure: line 21510: `    as_echo_body='eval expr "X$1" : "X\\(.*\\)"''
> Failed to setup build environment using 'autotools'!

I don't know the reason, but I confirmed this error of GTK was caused by your changes for config.ac and WebCore/GNUmakefile.am.

WebKit/chromium/features.gypi:48
 +          'ENABLE_DIRECTORY_UPLOAD=0',
I recommend enable ENABLE_DIRECTORY_UPLOAD for this file because
 - We can confirm build by buildbots
 - Changing features.gypi later is hard because of Bug#38926.

[John Gregg]

Created attachment 59778 [details]
Patch

[John Gregg]

(In reply to comment #3)
> (From update of attachment 59561 [details])
> 
> > checking whether to build gtk-doc documentation... no
> > checking for gtkdoc-check... /usr/bin/gtkdoc-check
> > ../../configure: line 21510: syntax error near unexpected token `('
> > ../../configure: line 21510: `    as_echo_body='eval expr "X$1" : "X\\(.*\\)"''
> > Failed to setup build environment using 'autotools'!
> 
> I don't know the reason, but I confirmed this error of GTK was caused by your changes for config.ac and WebCore/GNUmakefile.am.
> 

I think I found the typo (missing ").  Uploaded a new patch.

> WebKit/chromium/features.gypi:48
>  +          'ENABLE_DIRECTORY_UPLOAD=0',
> I recommend enable ENABLE_DIRECTORY_UPLOAD for this file because
>  - We can confirm build by buildbots
>  - Changing features.gypi later is hard because of Bug#38926.

Done.

[Kent Tamura]

Comment on attachment 59778 [details]
Patch

OK

[WebKit Commit Bot]

Comment on attachment 59778 [details]
Patch

Rejecting patch 59778 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1
Last 500 characters of output:
le WebKitLibraries/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops
Hunk #1 FAILED at 9.
1 out of 2 hunks FAILED -- saving rejects to file WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops.rej
patching file WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/Scripts/build-webkit
Hunk #1 succeeded at 61 with fuzz 2.

Full output: http://webkit-commit-queue.appspot.com/results/3281909

[John Gregg]

Committed r62049: <http://trac.webkit.org/changeset/62049>