Bug 41094 – Web Inspector: Inspector cleanup + better DevTools alignment with Inspector.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

WebCore:
- Removed a bunch of unused methods from all over the place
- Added client callbacks for states surviving navigation
- Implemented more user-friendly stub for InspectorFrontendHost.platform

WebKit/chromium
- Merged InspectorClient implementation into WebDevToolsAgent
- Changed the way WebDevToolsAgent is initialized (will break chromium bot, needs coordinated landing)
- Removed a lot of legacy code from WebDevToolsAgentImpl
- Removed a lot of overrides from DevTools.js
- Simplified devtools stubs
- Got rid of all logic from within InjectDispatch.js

We are now much cleaner and much more ready for remote debugging!

[Pavel Feldman]

Created attachment 59553 [details]
[PATCH] Proposed change. I still need to test it, but 99.9% of changes are ready for review.

[Pavel Feldman]

Created attachment 59554 [details]
[PATCH] Same with InspectorClientImpl files actually removed.

[Yury Semikhatsky]

Comment on attachment 59554 [details]
[PATCH] Same with InspectorClientImpl files actually removed.

WebKit/chromium/src/WebDevToolsAgentImpl.cpp:486
 +      if (!agent->m_apuAgentEnabled)
At first check if there is ApuAgent and dispatch the message just to it.

WebKit/chromium/src/WebViewImpl.cpp: 
 +  void WebViewImpl::setDevToolsAgent(WebDevToolsAgent* devToolsAgent)
It is likely to break layout tests. Make sure they are fine.

WebKit/chromium/src/js/InjectDispatch.js: 
 +  function close() {
Pleas make sure tests pass.

[Pavel Feldman]

Created attachment 59641 [details]
[PATCH] Review comments addressed.

[Yury Semikhatsky]

Comment on attachment 59641 [details]
[PATCH] Review comments addressed.

WebKit/chromium/src/WebDevToolsAgentImpl.cpp:491
 +      if (method.isEmpty() || exceptionCatcher.HasCaught())
do you need to check for jsDispatchOnClient.HasCaught here and above?

[Yury Semikhatsky]

Comment on attachment 59641 [details]
[PATCH] Review comments addressed.

r+ given interactive and layout tests pass.

[WebKit Review Bot]

http://trac.webkit.org/changeset/61766 might have broken Chromium Linux Release

[Pavel Feldman]

Landed as r61772