Bug 41088 - [Qt] support dumpChildFrameScrollPositions
Summary: [Qt] support dumpChildFrameScrollPositions
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on: 41261
Blocks:
  Show dependency tree / graph
 
Reported: 2010-06-23 11:36 PDT by Robert Hogan
Modified: 2010-07-03 03:59 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.52 KB, patch)
2010-06-23 11:46 PDT, Robert Hogan 		kenneth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-06-23 11:36:30 PDT 
support dumpChildFrameScrollPositions
Comment 1 Robert Hogan 2010-06-23 11:46:17 PDT 
Created attachment 59546 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-06-28 06:46:41 PDT 
Comment on attachment 59546 [details]
Patch

WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:678
 +          QList<QWebFrame *> children = frame->childFrames();
No space needed before *

WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:691
 +      QWebFrame* parent = qobject_cast<QWebFrame *>(frame->parent());
Neither here
Comment 3 Robert Hogan 2010-07-03 03:01:15 PDT 
Committed r62444: <http://trac.webkit.org/changeset/62444>
Comment 4 WebKit Review Bot 2010-07-03 03:20:08 PDT 
http://trac.webkit.org/changeset/62444 might have broken Qt Linux Release
Comment 5 Robert Hogan 2010-07-03 03:59:24 PDT 
(In reply to comment #4)
> http://trac.webkit.org/changeset/62444 might have broken Qt Linux Release

Just needed to update some test results to reflect support for the feature.

This was done in r62445.