Bug 41083 - fast/parser/broken-comments-vs-parsing mode no longer tests for what it used to test
Summary: fast/parser/broken-comments-vs-parsing mode no longer tests for what it used ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-23 11:05 PDT by Alexey Proskuryakov
Modified: 2010-06-23 12:13 PDT (History)
1 user (show)

See Also:

Attachments
proposed fix (1.35 KB, patch)
2010-06-23 11:21 PDT, Alexey Proskuryakov 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2010-06-23 11:05:12 PDT 
The comment should be treated as a comment, so hiding it inside <title> isn't good.
Comment 1 Alexey Proskuryakov 2010-06-23 11:21:00 PDT 
Created attachment 59537 [details]
proposed fix
Comment 2 Eric Seidel (no email) 2010-06-23 11:53:54 PDT 
Comment on attachment 59537 [details]
proposed fix

So the test used to fail to go into quirks mode because of the comment?  Are we sure that this placement of the comment will cause the same effect?
Comment 3 Alexey Proskuryakov 2010-06-23 12:13:37 PDT 
Committed <http://trac.webkit.org/changeset/61704>.

> So the test used to fail to go into quirks mode because of the comment?

Actually, vice versa - there is no DOCTYPE, so the test shouldn't be in strict mode. Bug 8626 was about strict mode being entered in error.

> Are we sure that this placement of the comment will cause the same effect?

It was a long time ago, but my recollection about that bug is that yes, the modified test should still cover it.