RESOLVED FIXED 41083
fast/parser/broken-comments-vs-parsing mode no longer tests for what it used to test 
https://bugs.webkit.org/show_bug.cgi?id=41083
Summary fast/parser/broken-comments-vs-parsing mode no longer tests for what it used ...
Alexey Proskuryakov
Reported 2010-06-23 11:05:12 PDT
The comment should be treated as a comment, so hiding it inside <title> isn't good.
Attachments
proposed fix (1.35 KB, patch)
2010-06-23 11:21 PDT, Alexey Proskuryakov 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-06-23 11:21:00 PDT
Created attachment 59537 [details] proposed fix
Eric Seidel (no email)
Comment 2 2010-06-23 11:53:54 PDT
Comment on attachment 59537 [details] proposed fix So the test used to fail to go into quirks mode because of the comment? Are we sure that this placement of the comment will cause the same effect?
Alexey Proskuryakov
Comment 3 2010-06-23 12:13:37 PDT
Committed <http://trac.webkit.org/changeset/61704>. > So the test used to fail to go into quirks mode because of the comment? Actually, vice versa - there is no DOCTYPE, so the test shouldn't be in strict mode. Bug 8626 was about strict mode being entered in error. > Are we sure that this placement of the comment will cause the same effect? It was a long time ago, but my recollection about that bug is that yes, the modified test should still cover it.
Note You need to log in before you can comment on or make changes to this bug.