Bug 41065 – [Qt] tst_QWebFrame::callQtInvokable() fails

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Jędrzej Nowacki]

The autotest fails on my computer.
Checked against git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

FAIL! : tst_QWebFrame::callQtInvokable() Compared values are not the same Actual (vmap.keys().size()): 0 Expected (2): 2 Loc: [/home/nierob/dev/WebKit-script/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(1275)]

[Andreas Kling]

Regression caused by <http://trac.webkit.org/changeset/61478> (the change to WebCore/bridge/qt/qt_runtime.cpp)

I don't see why getPropertyNames() would crash in that scenario, and cannot reproduce with the two mentioned tests (world-reuse.html and didClearWindowObject.html)

[Andreas Kling]

Created attachment 61925 [details]
Proposed patch

Proposed partial revert of <http://trac.webkit.org/changeset/61478>

[Robert Hogan]

(In reply to comment #2)
> Created an attachment (id=61925) [details]
> Proposed patch
> 
> Proposed partial revert of <http://trac.webkit.org/changeset/61478>

Note to self: make sure I pass the unit tests in future too.

If you can't recreate that's fair enough - if I can still recreate when you revert I'll create a new bug for it. The two tests in question are already skipped.

[Andreas Kling]

Comment on attachment 61925 [details]
Proposed patch

Clearing flags on attachment: 61925

Committed r64011: <http://trac.webkit.org/changeset/64011>

[Andreas Kling]

All reviewed patches have been landed.  Closing bug.

[Simon Hausmann]

Revision r64011 cherry-picked into qtwebkit-2.1 with commit f1ec6bfb720b632660b49880cc088084bb15175c