Bug 41056 - [chromium] Make page format data methods accessible from Chromium
Summary: [chromium] Make page format data methods accessible from Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Yuzo Fujishima
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-23 03:00 PDT by Yuzo Fujishima
Modified: 2010-06-23 03:59 PDT (History)
5 users (show)

See Also:


Attachments
Make page format data methods accessible from Chromium (3.32 KB, patch)
2010-06-23 03:07 PDT, Yuzo Fujishima
no flags Details | Formatted Diff | Diff
Addressed comment. (3.34 KB, patch)
2010-06-23 03:25 PDT, Yuzo Fujishima
hamaji: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuzo Fujishima 2010-06-23 03:00:00 PDT
Page format data methods for CSS3 Paged Media were added by https://bugs.webkit.org/show_bug.cgi?id=37538
Make them accessible from Chromium by adding methods to WebFrameImpl.
Comment 1 Yuzo Fujishima 2010-06-23 03:07:18 PDT
Created attachment 59498 [details]
Make page format data methods accessible from Chromium
Comment 2 Shinichiro Hamaji 2010-06-23 03:16:56 PDT
Comment on attachment 59498 [details]
Make page format data methods accessible from Chromium

Looks good, except for a nitpick in your comment.

WebKit/chromium/public/WebFrame.h:411
 +      // Returns the page area rectangle in pixels, assuming 96 dpi.
I'd say pixels per inch instead of DPI. DPI can be a confusing as points-per-inch is different from pixels-per-inch.
Comment 3 Yuzo Fujishima 2010-06-23 03:25:58 PDT
Created attachment 59499 [details]
Addressed comment.
Comment 4 Shinichiro Hamaji 2010-06-23 03:26:36 PDT
Comment on attachment 59499 [details]
Addressed comment.

Looks good.
Comment 5 Yuzo Fujishima 2010-06-23 03:29:54 PDT
Committed r61680: <http://trac.webkit.org/changeset/61680>
Comment 6 WebKit Review Bot 2010-06-23 03:59:04 PDT
http://trac.webkit.org/changeset/61680 might have broken GTK Linux 64-bit Debug