RESOLVED FIXED 41056
[chromium] Make page format data methods accessible from Chromium 
https://bugs.webkit.org/show_bug.cgi?id=41056
Summary [chromium] Make page format data methods accessible from Chromium
Yuzo Fujishima
Reported 2010-06-23 03:00:00 PDT
Page format data methods for CSS3 Paged Media were added by https://bugs.webkit.org/show_bug.cgi?id=37538 Make them accessible from Chromium by adding methods to WebFrameImpl.
Attachments
Make page format data methods accessible from Chromium (3.32 KB, patch)
2010-06-23 03:07 PDT, Yuzo Fujishima 		no flags
DetailsFormatted DiffDiff
Addressed comment. (3.34 KB, patch)
2010-06-23 03:25 PDT, Yuzo Fujishima 		hamaji: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yuzo Fujishima
Comment 1 2010-06-23 03:07:18 PDT
Created attachment 59498 [details] Make page format data methods accessible from Chromium
Shinichiro Hamaji
Comment 2 2010-06-23 03:16:56 PDT
Comment on attachment 59498 [details] Make page format data methods accessible from Chromium Looks good, except for a nitpick in your comment. WebKit/chromium/public/WebFrame.h:411 + // Returns the page area rectangle in pixels, assuming 96 dpi. I'd say pixels per inch instead of DPI. DPI can be a confusing as points-per-inch is different from pixels-per-inch.
Yuzo Fujishima
Comment 3 2010-06-23 03:25:58 PDT
Created attachment 59499 [details] Addressed comment.
Shinichiro Hamaji
Comment 4 2010-06-23 03:26:36 PDT
Comment on attachment 59499 [details] Addressed comment. Looks good.
Yuzo Fujishima
Comment 5 2010-06-23 03:29:54 PDT
Committed r61680: <http://trac.webkit.org/changeset/61680>
WebKit Review Bot
Comment 6 2010-06-23 03:59:04 PDT
http://trac.webkit.org/changeset/61680 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.