Bug 41047 - Unify three methods to decide whether a renderer should be created
Summary: Unify three methods to decide whether a renderer should be created
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-23 00:14 PDT by Nikolas Zimmermann
Modified: 2010-07-01 14:38 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2010-06-23 00:14:20 PDT 
We currently have three code paths doing decisions on whether a renderer should be created/destroyed:
- Node::rendererIsNeeded(RenderStyle*) - decide whether a Node need a renderer based on RenderStyle information (display() != NONE, etc.)
- Node::childShouldCreateRenderer(Node*) - decide whether a children of a certain element should get a renderer
- RenderObject::isChildAllowed() - checks whether a new renderer can be appended, if not the renderer is destroyed again (see createRendererIfNeeded())

These code paths should ideally be unified.