editing/execCommand/copy-without-selection.html fails on Qt after r61637 Looks like the test somehow depended on NULL characters being stripped during fragment parsing. Just not sure how it did that since it's clearly setting the string "SUCCESS" and getting out "S\0U\0..." converted to \xFFFD in the parser. The failure appears to be Qt specific.
--- /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/editing/execCommand/copy-without-selection-expected.txt 2010-06-22 16:54:03.788189611 -0700 +++ /home/webkitbuildbot/slaves/release32bit/buildslave/qt-linux-release/build/layout-test-results/editing/execCommand/copy-without-selection-actual.txt 2010-06-22 16:54:03.788189611 -0700 @@ -1 +1 @@ -SUCCESS +S�U�C�C�E�S�S�
� is \xFFFD, the HTML5 replacement character.
I think the Qt code might be setting a UTF-16 string as UTF-8, and we just didn't notice before. :)
Ooooooooh , i'm soooo goood! Bad bad Qt: http://trac.webkit.org/browser/trunk/WebCore/platform/qt/ClipboardQt.cpp#L146
See how the Mac code deals with the arguments as strings: http://trac.webkit.org/browser/trunk/WebCore/platform/mac/ClipboardMac.mm#L238
Committed r61641: <http://trac.webkit.org/changeset/61641>
Skipped the test until the ClipboardQt::setData bug can be fixed.
Created attachment 59470 [details] Proposed patch Use QMimeData::text() and QMimeData::setText() for "text/plain" data to avoid encoding confusion.
Created attachment 59638 [details] Proposed patch, more ChangeLog
Comment on attachment 59638 [details] Proposed patch, more ChangeLog Rejecting patch 59638 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Simon Hausmann', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/qt/Skipped Hunk #1 FAILED at 5446. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/qt/ClipboardQt.cpp Full output: http://webkit-commit-queue.appspot.com/results/3281789
Created attachment 59828 [details] Proposed patch, updated to apply
Comment on attachment 59828 [details] Proposed patch, updated to apply Clearing flags on attachment: 59828 Committed r61968: <http://trac.webkit.org/changeset/61968>
All reviewed patches have been landed. Closing bug.