Bug 41020 - Slider labels do not update as you move the sliders on this page
Summary: Slider labels do not update as you move the sliders on this page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: http://slides.html5rocks.com/#slide39
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 16:21 PDT by Simon Fraser (smfr)
Modified: 2010-08-20 11:50 PDT (History)
2 users (show)

See Also:

Attachments
Testcase (996 bytes, text/html)
2010-08-19 12:17 PDT, Simon Fraser (smfr) 		no flags Details
Patch (10.88 KB, patch)
2010-08-19 14:26 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (7.43 KB, patch)
2010-08-20 11:35 PDT, Simon Fraser (smfr) 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-06-22 16:21:09 PDT 
Load http://slides.html5rocks.com/#slide39 and play with the box-shadow sliders. Note how the numbers next to the sliders fail to update when moving the slider thumb. However, we do move the slider around as if we were doing layout.

The text-shadow sliders work OK.
Comment 1 mitz 2010-06-22 16:32:26 PDT 
This only happens in the two-column configuration. If I disable the -webkit-column-count: 2; property, I don’t see the problem.
Comment 2 Simon Fraser (smfr) 2010-08-19 12:17:21 PDT 
Created attachment 64886 [details]
Testcase
Comment 3 Simon Fraser (smfr) 2010-08-19 12:18:23 PDT 
The issue is that 'repaintTop', returned by layoutInlineChildren(), doesn't take columns into account.
Comment 4 Simon Fraser (smfr) 2010-08-19 12:21:50 PDT 
Ah, this would be:

        // FIXME: Deal with multiple column repainting.  We have to split the repaint
        // rect up into multiple rects if it spans columns.

in RenderBlock::layoutBlock()
Comment 5 Simon Fraser (smfr) 2010-08-19 14:26:09 PDT 
Created attachment 64899 [details]
Patch
Comment 6 Simon Fraser (smfr) 2010-08-20 11:00:20 PDT 
Comment on attachment 64899 [details]
Patch

Going to update this based on feedback from hyatt.
Comment 7 Simon Fraser (smfr) 2010-08-20 11:35:05 PDT 
Created attachment 64966 [details]
Patch
Comment 8 Simon Fraser (smfr) 2010-08-20 11:50:12 PDT 
http://trac.webkit.org/changeset/65746