RESOLVED FIXED Bug 41015
Change the encode functions to be specializations of a class template
https://bugs.webkit.org/show_bug.cgi?id=41015
Summary Change the encode functions to be specializations of a class template
Anders Carlsson
Reported 2010-06-22 15:19:22 PDT
Change the encode functions to be specializations of a class template
Attachments
Patch (11.91 KB, patch)
2010-06-22 15:20 PDT, Anders Carlsson
mitz: review+
Anders Carlsson
Comment 1 2010-06-22 15:20:57 PDT
mitz
Comment 2 2010-06-22 15:27:33 PDT
Comment on attachment 59420 [details] Patch > Index: WebKit/mac/ChangeLog > =================================================================== > --- WebKit/mac/ChangeLog (revision 61630) > +++ WebKit/mac/ChangeLog (working copy) > @@ -1,3 +1,12 @@ > +2010-06-22 Anders Carlsson <andersca@apple.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Change the encode functions to be specializations of a class template > + https://bugs.webkit.org/show_bug.cgi?id=41015 > + > + * Plugins/Hosted/NetscapePluginHostProxy.h: > + > 2010-06-22 Anders Carlsson <andersca@apple.com> > > Reviewed by Sam Weinig. > Index: WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h > =================================================================== > --- WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h (revision 61627) > +++ WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h (working copy) > @@ -84,11 +84,7 @@ private: > mach_port_t m_clientPort; > mach_port_t m_portSet; > > -#ifdef USE_LIBDISPATCH > - dispatch_source_t m_clientPortSource; > -#else > RetainPtr<CFRunLoopSourceRef> m_clientPortSource; > -#endif > mach_port_t m_pluginHostPort; > RetainPtr<CFMachPortRef> m_deadNameNotificationPort; > This doesn’t seem to be related. Please don’t land it as part of this patch.
Anders Carlsson
Comment 3 2010-06-22 16:23:10 PDT
Note You need to log in before you can comment on or make changes to this bug.