Bug 41015 - Change the encode functions to be specializations of a class template
Summary: Change the encode functions to be specializations of a class template
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 15:19 PDT by Anders Carlsson
Modified: 2010-06-22 16:23 PDT (History)
0 users

See Also:

Attachments
Patch (11.91 KB, patch)
2010-06-22 15:20 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-06-22 15:19:22 PDT 
Change the encode functions to be specializations of a class template
Comment 1 Anders Carlsson 2010-06-22 15:20:57 PDT 
Created attachment 59420 [details]
Patch
Comment 2 mitz 2010-06-22 15:27:33 PDT 
Comment on attachment 59420 [details]
Patch

> Index: WebKit/mac/ChangeLog
> ===================================================================
> --- WebKit/mac/ChangeLog	(revision 61630)
> +++ WebKit/mac/ChangeLog	(working copy)
> @@ -1,3 +1,12 @@
> +2010-06-22  Anders Carlsson  <andersca@apple.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Change the encode functions to be specializations of a class template
> +        https://bugs.webkit.org/show_bug.cgi?id=41015
> +
> +        * Plugins/Hosted/NetscapePluginHostProxy.h:
> +
>  2010-06-22  Anders Carlsson  <andersca@apple.com>
>  
>          Reviewed by Sam Weinig.
> Index: WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h
> ===================================================================
> --- WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h	(revision 61627)
> +++ WebKit/mac/Plugins/Hosted/NetscapePluginHostProxy.h	(working copy)
> @@ -84,11 +84,7 @@ private:
>      mach_port_t m_clientPort;
>      mach_port_t m_portSet;
>      
> -#ifdef USE_LIBDISPATCH
> -    dispatch_source_t m_clientPortSource;
> -#else
>      RetainPtr<CFRunLoopSourceRef> m_clientPortSource;
> -#endif
>      mach_port_t m_pluginHostPort;
>      RetainPtr<CFMachPortRef> m_deadNameNotificationPort;
>      

This doesn’t seem to be related. Please don’t land it as part of this patch.
Comment 3 Anders Carlsson 2010-06-22 16:23:10 PDT 
Committed r61634: <http://trac.webkit.org/changeset/61634>