Bug 41014 – [GTK] Add support for the progress tag

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

The GTK+ port does not yet support the HTML5 progress tag. The only necessity is to add support to RenderThemeGtk for this control.

[Martin Robinson]

Created attachment 59424 [details]
Add support for rendering the progress element

[WebKit Review Bot]

Attachment 59424 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/gtk/gtkdrawing.h:492:  moz_gtk_get_progress_widget is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WARNING: File exempt from style guide. Skipping: "WebCore/platform/gtk/gtk2drawing.c"
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

This above is a bug in the style checker. I've filed it here: https://bugs.webkit.org/show_bug.cgi?id=41017

[Xan Lopez]

Comment on attachment 59424 [details]
Add support for rendering the progress element

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>--- a/WebCore/platform/gtk/RenderThemeGtk.cpp
>+++ b/WebCore/platform/gtk/RenderThemeGtk.cpp
>@@ -34,6 +34,9 @@
> #include "MediaControlElements.h"
> #include "NotImplemented.h"
> #include "RenderBox.h"
>+#if ENABLE(PROGRESS_TAG)
>+#include "RenderProgress.h"
>+#endif

Style guide says this has to go at the end of the includes in its own block.


>+bool RenderThemeGtk::paintProgressBar(RenderObject* renderObject, const RenderObject::PaintInfo& paintInfo, const IntRect& rect)
>+{
>+    if (!renderObject->isProgress())
>+        return true;
>+
>+    GtkWidget* progressBarWidget = moz_gtk_get_progress_widget();
>+    if (!progressBarWidget)
>+        return true;
>+
>+    if (paintMozillaGtkWidget(this, MOZ_GTK_PROGRESSBAR, renderObject, paintInfo, rect))
>+        return true;
>+
>+    IntRect chunkRect(rect);
>+    RenderProgress* renderProgress = toRenderProgress(renderObject);
>+
>+    chunkRect.setHeight(chunkRect.height() - (2 * progressBarWidget->style->ythickness));
>+    chunkRect.setY(chunkRect.y() + progressBarWidget->style->ythickness);
>+    chunkRect.setWidth(chunkRect.width() - (2 * progressBarWidget->style->xthickness));

Don't access style like that, it won't compile with GSEAL enabled.

r- for the GSEAL stuff.

[Martin Robinson]

Created attachment 59926 [details]
Updated patch with Xan's suggestions

[WebKit Review Bot]

Attachment 59926 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/gtk/gtkdrawing.h:492:  moz_gtk_get_progress_widget is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WARNING: File exempt from style guide. Skipping: "WebCore/platform/gtk/gtk2drawing.c"
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 59926 [details]
Updated patch with Xan's suggestions

Patch has landed (r62034), so I'm clearing the flags.

[WebKit Review Bot]

http://trac.webkit.org/changeset/62034 might have broken GTK Linux 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/62032
http://trac.webkit.org/changeset/62033
http://trac.webkit.org/changeset/62034
http://trac.webkit.org/changeset/62031

[Gustavo Noronha (kov)]

So this bug is done, then? =) I'll close it, feel free to reopen if I'm mistaken.

[Martin Robinson]

Yep! This should be complete.