Bug 40990 - [GTK] Bots are showing lots of GTK_IS_CONTAINER critical warnings
Summary: [GTK] Bots are showing lots of GTK_IS_CONTAINER critical warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 09:39 PDT by Martin Robinson
Modified: 2010-08-18 16:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch for this issue (1.38 KB, patch)
2010-06-22 11:03 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff
Another approach to this issue (4.79 KB, patch)
2010-08-18 13:42 PDT, Martin Robinson
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-06-22 09:39:33 PDT
This seems to be an issue with ScrollViewGtk creating native scrollbars too late in the lifetime of a view. For now we can simply not add the scrollbar in that case. I think the real long term solution is to entirely remove native scrollbars and rely on the theme drawing code to render them.
Comment 1 Martin Robinson 2010-06-22 11:03:05 PDT
Created attachment 59391 [details]
Patch for this issue
Comment 2 Xan Lopez 2010-06-24 11:56:39 PDT
Comment on attachment 59391 [details]
Patch for this issue

As commented on jabber, relying on a dead widget to do something or other is not a good idea. We have to find other solution.
Comment 3 Martin Robinson 2010-08-18 13:42:57 PDT
Created attachment 64764 [details]
Another approach to this issue
Comment 4 Gustavo Noronha (kov) 2010-08-18 13:48:16 PDT
Comment on attachment 64764 [details]
Another approach to this issue

This looks sane to me, please run the API tests too. Some going around in build.webkit.org would be a plus, given how fragile this code still seems to be =(
Comment 5 Martin Robinson 2010-08-18 15:45:36 PDT
Committed r65635: <http://trac.webkit.org/changeset/65635>
Comment 6 WebKit Review Bot 2010-08-18 16:18:45 PDT
http://trac.webkit.org/changeset/65635 might have broken Chromium Mac Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/65635
http://trac.webkit.org/changeset/65636
http://trac.webkit.org/changeset/65637