Bug 40986 – Change to Vertical Alignment of MathML Constructs to Use the Baseline

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alex Milowski]

Created attachment 59371 [details]
Patch to change to baseline alignment.

This patch changes the way all MathML elements are rendered so the align against a calculated baseline.  This fixes a number of layout bugs and cleans up the implementation.

The patch is large because all the tests had to have their results reset.  The actual code changes are relatively small.

[Kenneth Rohde Christiansen]

Comment on attachment 59371 [details]
Patch to change to baseline alignment.

LGTM.

165             int heightDiff = (m_scripts->offsetHeight() - maxHeight) / 2;
 166             if (heightDiff < 0) 
 167                 heightDiff = 0;

maybe add a comment to when this can happen?

[Kenneth Rohde Christiansen]

Comment on attachment 59371 [details]
Patch to change to baseline alignment.

LGTM.

165             int heightDiff = (m_scripts->offsetHeight() - maxHeight) / 2;
 166             if (heightDiff < 0) 
 167                 heightDiff = 0;

maybe add a comment to when this can happen?

WebCore/mathml/RenderMathMLUnderOver.cpp:255
 +              baseline += static_cast<int>((zoomFactor > 1.25 ? 2 : 3) * zoomFactor);
ieck :-) good that you added a FIXME at least.

[Alex Milowski]

(In reply to comment #1)
> (From update of attachment 59371 [details])
> LGTM.
> 
> 165             int heightDiff = (m_scripts->offsetHeight() - maxHeight) / 2;
>  166             if (heightDiff < 0) 
>  167                 heightDiff = 0;
> 
> maybe add a comment to when this can happen?

Only if the base is bigger than the scripts.   That shouldn't happen unless you are in the process of row height calculation.  I should add a comment to that effect.

[Alex Milowski]

(In reply to comment #2)
> (From update of attachment 59371 [details])
> LGTM.
> 
> 165             int heightDiff = (m_scripts->offsetHeight() - maxHeight) / 2;
>  166             if (heightDiff < 0) 
>  167                 heightDiff = 0;
> 
> maybe add a comment to when this can happen?
> 
> WebCore/mathml/RenderMathMLUnderOver.cpp:255
>  +              baseline += static_cast<int>((zoomFactor > 1.25 ? 2 : 3) * zoomFactor);
> ieck :-) good that you added a FIXME at least.

There is some padding or margin that is expanding and I can't quite figure it out.  Very icky indeed.

[WebKit Commit Bot]

Comment on attachment 59371 [details]
Patch to change to baseline alignment.

Clearing flags on attachment: 59371

Committed r61861: <http://trac.webkit.org/changeset/61861>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.