Bug 40964 – JSC bindings for Image Resizer API (recreated due to commit-queue bug)

• Status: RESOLVED
• Resolution: INVALID
• Component: Images

[Sterling Swigart]

This patch exposes the classes and their callbacks to JSC through Image.webkitGetImage. The API is functionally incomplete, so it only will ever call the error callback or throw exceptions.

Recreated from 40854:

(In reply to comment #5)
> (From update of attachment 59165 [details])
> I'm pretty sure you can create these bindings without any extra code.  If you have trouble, you should ask dumi.
> 

Done.

> WebCore/ChangeLog:59
>  +  2010-06-18  Sterling Swigart  <[e-mail]>
> You have two ChangeLogs in this patch.
> 

Extras deleted, ChangeLogs recreated anyway.

> WebCore/bindings/js/JSCustomImageResizerErrorCallback.cpp:47
>  +  JSCustomImageResizerErrorCallback::JSCustomImageResizerErrorCallback(JSObject* callback, JSDOMGlobalObject* globalObject)
> We should be able to auto-generate these callbacks now.  There are some examples in the database bindings.
> 

Done; I changed CodeGenerator.pm to allow for this.

> WebCore/html/HTMLImageElement.idl:56
>  +          [Custom] void webkitGetImage(in DOMString mimeType, in ImageResizerSuccessCallback successCallback, [Optional] in ImageResizerErrorCallback errorCallback, [Optional] in ResizeOptions options)
> This shouldn't be custom.

This is currently in discussion, but I'm still looking for further feedback regarding this patch.

[Sterling Swigart]

Created attachment 59325 [details]
Patch 2: JSC bindings

[Sterling Swigart]

My patches are still failing with no explanation. . . .

[Sterling Swigart]

This bug was an attempt to trick the buildbot into giving me reasons for the failures. It did not work, however, so I am invalidating the bug.