Bug 40962 - webkit-patch should refuse to run under Win32 Python
Summary: webkit-patch should refuse to run under Win32 Python
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-21 19:08 PDT by Dirk Pranke
Modified: 2010-08-11 06:14 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2010-06-21 19:09 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2010-06-21 19:39 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-06-21 19:08:16 PDT 
webkit-patch should refuse to run under Win32 Python
Comment 1 Dirk Pranke 2010-06-21 19:09:59 PDT 
Created attachment 59322 [details]
Patch
Comment 2 Dirk Pranke 2010-06-21 19:11:25 PDT 
        Given that there are lots of places in webkit-patch's code that
        assume unix-style filenames (forward slashes), webkit-patch fails
        with weird file-not-found errors when run under a native windows
        Python. It would be nice if we just trapped this and errored out
        at the beginning, rather than producing unpredictable errors.
Comment 3 Dirk Pranke 2010-06-21 19:39:21 PDT 
Created attachment 59326 [details]
Patch
Comment 4 Eric Seidel (no email) 2010-07-12 20:12:14 PDT 
Comment on attachment 59326 [details]
Patch

OK.
Comment 5 Adam Barth 2010-08-10 22:24:52 PDT 
Comment on attachment 59326 [details]
Patch

That's too bad.
Comment 6 WebKit Commit Bot 2010-08-10 23:19:51 PDT 
Comment on attachment 59326 [details]
Patch

Clearing flags on attachment: 59326

Committed r65126: <http://trac.webkit.org/changeset/65126>
Comment 7 WebKit Commit Bot 2010-08-10 23:19:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2010-08-11 06:14:17 PDT 
http://trac.webkit.org/changeset/65126 might have broken Leopard Intel Debug (Tests)