Bug 40960 – REGRESSION: text-shadow CSS applied to SVG no longer works

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Simon Fraser (smfr)]

text-shadow applied to SVG used to work before http://trac.webkit.org/changeset/61393, and no longer does.

[Nikolas Zimmermann]

Right, this was intentional. I'm not sure whether we want to support it at all?
AFAIK we don't have any testcases for this in trunk, at least no testcase that I could have broken?
Please correct me if I'm wrong!

[Simon Fraser (smfr)]

text-shadow support in SVG was added recently, and was for an internal Apple customer. We absolutely need it to work.

I agree that there is a lack of testcases.

[Nikolas Zimmermann]

I can easily add it back, if we do need it. No problem at all. Can you supply me with a testcase?

[Simon Fraser (smfr)]

Created attachment 59375 [details]
Testcase

[Beth Dakin]

I was confused when Simon mentioned this to me yesterday, and it took me a little while to remember why. Supporting text-shadow on SVG is NOT a new feature. text-shadow has worked on SVG pretty much since text-shadow has worked in regular CSS and HTML. The new feature is -webkit-svg-shadow, and that allows shadows on arbitrary SVG element. -webkit-svg-shadow did have the same effect as text-shadow when I implemented it 6 months back or so, and I probably should have added test cases demonstrating it. But fundamentally, text shadow was an existing feature. The new feature was -webkit-svg-shadow.

[Beth Dakin]

And just to be clear, text-shadow and -webkit-svg-shadow should still both continue to work on text. text-shadow is a feature that has been shipping in Safari since at least Safari 4.0.4. (I know it was shipping earlier than that, but I don't have an earlier version handy to test.) And -webkit-svg-shadow shipped with Safari 5. I am sure other WebKit-based browsers have shipped these features too, and we try to avoid removing features that have shipped in any browser at all costs.

[Dirk Schulze]

(In reply to comment #6)
> And just to be clear, text-shadow and -webkit-svg-shadow should still both continue to work on text. text-shadow is a feature that has been shipping in Safari since at least Safari 4.0.4. (I know it was shipping earlier than that, but I don't have an earlier version handy to test.) And -webkit-svg-shadow shipped with Safari 5. I am sure other WebKit-based browsers have shipped these features too, and we try to avoid removing features that have shipped in any browser at all costs.

If both, text-shadow and -webkit-svg-shadow, should be useable for SVG text elements, what should happen if we apply both to a text? I tried it on WebKitGtk and the prefered shadow was the text-shadow and it doesn't change something on the first few, but the background turned to the color defined by webkit-svg-shadow on selecting the text. I believe that this is not expected.
It isn't realy topic related and we can open a new bug report for it if needed.

[Nikolas Zimmermann]

Created attachment 59769 [details]
Initial patch

Readd text-shadow support, this time supporting multiple shadows.
Doesn't work exactly like HTML, because of the way stroke/fill is painted in SVG: seperated.

When applying a shadow to a stroked SVG text, the shadow will be stroked as well. That's the same like we did before (before I removed text-shadow support), but I just wanted to mention it, in case someone wonders when looking at the expected.png. Adding a testcase which shows SVG/HTML text-shadow in comparision.

[Dirk Schulze]

Comment on attachment 59769 [details]
Initial patch

WebCore/rendering/SVGInlineTextBox.cpp:577
 +              extraOffset = roundedIntSize(applyShadowToGraphicsContext(context, shadow, shadowRect, false /* stroked */, true /* opaque */));
roundedIntSize should go away, like discussed in IRC. 

r=me with this little change.

[Nikolas Zimmermann]

*** Bug 37468 has been marked as a duplicate of this bug. ***

[Nikolas Zimmermann]

Landed in r62099.

[Nikolas Zimmermann]

Landed in r62100.