RESOLVED FIXED Bug 40949
Add PluginInfoStore class
https://bugs.webkit.org/show_bug.cgi?id=40949
Summary Add PluginInfoStore class
Anders Carlsson
Reported 2010-06-21 15:47:52 PDT
Add PluginInfoStore class
Attachments
Patch (13.66 KB, patch)
2010-06-21 15:50 PDT, Anders Carlsson
sam: review+
Anders Carlsson
Comment 1 2010-06-21 15:50:48 PDT
Sam Weinig
Comment 2 2010-06-21 15:54:28 PDT
Comment on attachment 59301 [details] Patch > Index: WebKit2/Shared/WebPreferencesStore.h > =================================================================== > --- WebKit2/Shared/WebPreferencesStore.h (revision 61578) > +++ WebKit2/Shared/WebPreferencesStore.h (working copy) > @@ -43,6 +43,7 @@ struct WebPreferencesStore { > { > encoder.encode(javaScriptEnabled); > encoder.encode(loadsImagesAutomatically); > + encoder.encode(pluginsEnabled); > encoder.encode(minimumFontSize); > encoder.encode(minimumLogicalFontSize); > encoder.encode(defaultFontSize); > @@ -61,6 +62,8 @@ struct WebPreferencesStore { > return false; > if (!decoder.decode(s.loadsImagesAutomatically)) > return false; > + if (!decoder.decode(s.pluginsEnabled)) > + return false; > if (!decoder.decode(s.minimumFontSize)) > return false; > if (!decoder.decode(s.minimumLogicalFontSize)) > @@ -86,6 +89,8 @@ struct WebPreferencesStore { > > bool javaScriptEnabled; > bool loadsImagesAutomatically; > + bool pluginsEnabled; You should mention in your changelog that you are also making this change to the preferences. Otherwise, looks good. r=me.
Anders Carlsson
Comment 3 2010-06-21 16:00:25 PDT
Note You need to log in before you can comment on or make changes to this bug.