Bug 40949 - Add PluginInfoStore class
Summary: Add PluginInfoStore class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-21 15:47 PDT by Anders Carlsson
Modified: 2010-06-21 16:00 PDT (History)
0 users

See Also:


Attachments
Patch (13.66 KB, patch)
2010-06-21 15:50 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-06-21 15:47:52 PDT
Add PluginInfoStore class
Comment 1 Anders Carlsson 2010-06-21 15:50:48 PDT
Created attachment 59301 [details]
Patch
Comment 2 Sam Weinig 2010-06-21 15:54:28 PDT
Comment on attachment 59301 [details]
Patch

> Index: WebKit2/Shared/WebPreferencesStore.h
> ===================================================================
> --- WebKit2/Shared/WebPreferencesStore.h	(revision 61578)
> +++ WebKit2/Shared/WebPreferencesStore.h	(working copy)
> @@ -43,6 +43,7 @@ struct WebPreferencesStore {
>      {
>          encoder.encode(javaScriptEnabled);
>          encoder.encode(loadsImagesAutomatically);
> +        encoder.encode(pluginsEnabled);
>          encoder.encode(minimumFontSize);
>          encoder.encode(minimumLogicalFontSize);
>          encoder.encode(defaultFontSize);
> @@ -61,6 +62,8 @@ struct WebPreferencesStore {
>              return false;
>          if (!decoder.decode(s.loadsImagesAutomatically))
>              return false;
> +        if (!decoder.decode(s.pluginsEnabled))
> +            return false;
>          if (!decoder.decode(s.minimumFontSize))
>              return false;
>          if (!decoder.decode(s.minimumLogicalFontSize))
> @@ -86,6 +89,8 @@ struct WebPreferencesStore {
>  
>      bool javaScriptEnabled;
>      bool loadsImagesAutomatically;
> +    bool pluginsEnabled;
You should mention in your changelog that you are also making this change to the preferences.

Otherwise, looks good. r=me.
Comment 3 Anders Carlsson 2010-06-21 16:00:25 PDT
Committed r61587: <http://trac.webkit.org/changeset/61587>