Bug 40940 – Add message passing support to the WebKit2 API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Sam Weinig]

We need a generic string based message passing API for WebKit2 to communicate from the injected bundle to the WebContext and vice versa.

[Sam Weinig]

Created attachment 59284 [details]
patch

[WebKit Review Bot]

Attachment 59284 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/WebContextInjectedBundleClient.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/UIProcess/WebProcessProxy.cpp:140:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/UIProcess/WebContextInjectedBundleClient.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 59284 [details]
patch

> Index: WebKit2/ChangeLog
> ===================================================================
> --- WebKit2/ChangeLog	(revision 61572)
> +++ WebKit2/ChangeLog	(working copy)
> @@ -1,3 +1,55 @@
> [phone]  Sam Weinig  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
> +        Add message passing support to the WebKit2 API.
> +        
> +        Adds message passing for both InjectedBundle -> WebContex 
> +        and WebContex -> InjectedBundle.
> +

Tyop, "contex".

> +
> +// Messages sent from the web process to the WebProcessProxy.

Should this say "from the WebProcess"?

>  
> +void WebProcess::postMessageToInjectedBundle(const String& message)
> +{
> +    if (!m_injectedBundle)
> +        return;
> +
> +    m_injectedBundle->didRecieveMessage(message);
> +}

I think this should be named forwardMessageToInjectedBundle.

Looks good otherwise, r=me

[Sam Weinig]

Landed in r61579.

[WebKit Review Bot]

http://trac.webkit.org/changeset/61579 might have broken SnowLeopard Intel Release (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/61579
http://trac.webkit.org/changeset/61580

[phanindra srungavarapu]

So how do we do this? can anyone point me to any documentation on how to pass messages from webkitview to application?