Bug 40930 - [EFL] Implement methods to create a new window
Summary: [EFL] Implement methods to create a new window
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Lucas De Marchi
URL:
Keywords:
Depends on:
Blocks: 41005
  Show dependency treegraph
 
Reported: 2010-06-21 11:39 PDT by Lucas De Marchi
Modified: 2010-06-23 12:40 PDT (History)
4 users (show)

See Also:


Attachments
Patch (16.80 KB, patch)
2010-06-21 11:40 PDT, Lucas De Marchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas De Marchi 2010-06-21 11:39:14 PDT
[EFL] Implement methods to create a new window
Comment 1 Lucas De Marchi 2010-06-21 11:40:21 PDT
Created attachment 59267 [details]
Patch
Comment 2 Leandro Pereira 2010-06-21 14:18:44 PDT
I'm not a reviewer, this is an informal review.

LGTM.
Comment 3 Gustavo Noronha (kov) 2010-06-23 07:15:39 PDT
Comment on attachment 59267 [details]
Patch

Having methods to query all properties of a type looks weird to me, but that is your API, so your call to me =). Looks right.
Comment 4 Leandro Pereira 2010-06-23 12:40:07 PDT
Comment on attachment 59267 [details]
Patch

Clearing flags on attachment: 59267

Committed r61706: <http://trac.webkit.org/changeset/61706>
Comment 5 Leandro Pereira 2010-06-23 12:40:19 PDT
All reviewed patches have been landed.  Closing bug.