Bug 40917 - [Chromium] Add a sanity test for heap profiler
Summary: [Chromium] Add a sanity test for heap profiler
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
Depends on:
Reported: 2010-06-21 07:53 PDT by Mikhail Naganov
Modified: 2010-06-22 05:12 PDT (History)
2 users (show)

See Also:

patch (2.22 KB, patch)
2010-06-21 07:56 PDT, Mikhail Naganov
yurys: review-
Details | Formatted Diff | Diff
return added (2.26 KB, patch)
2010-06-22 04:29 PDT, Mikhail Naganov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2010-06-21 07:53:54 PDT
This is to avoid breaking it next time you switch to a new debugging protocol.
Comment 1 Mikhail Naganov 2010-06-21 07:56:01 PDT
Created attachment 59251 [details]

The corresponding Chromium code is here: http://codereview.chromium.org/2846019
Comment 2 Yury Semikhatsky 2010-06-22 00:43:06 PDT
Comment on attachment 59251 [details]

 +                  test.releaseControl();
Also return from the function, owtherwise test.fail will be called as well. 

 +          [Chromium] Add a sanity test for heap profiler.
Can you implement it as a layout test instead?
Comment 3 Mikhail Naganov 2010-06-22 04:29:44 PDT
Created attachment 59359 [details]
return added

Added a 'return'. But I must note, that I ran the tests, and it looks like after it reports success, reporting a failure just doesn't count.

It seems currently impossible to implement it as a layout test, because the panel is Chromium-only, and resides in chromium platform code.
Comment 4 Mikhail Naganov 2010-06-22 05:12:40 PDT
Manually committed as http://trac.webkit.org/changeset/61613

    2010-06-21  Mikhail Naganov  <mnaganov@chromium.org>
            Reviewed by Pavel Feldman.
            [Chromium] Add a sanity test for heap profiler.
            * src/js/Tests.js: