Bug 40917 – [Chromium] Add a sanity test for heap profiler

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

This is to avoid breaking it next time you switch to a new debugging protocol.

[Mikhail Naganov]

Created attachment 59251 [details]
patch

The corresponding Chromium code is here: http://codereview.chromium.org/2846019

[Yury Semikhatsky]

Comment on attachment 59251 [details]
patch

WebKit/chromium/src/js/Tests.js:486
 +                  test.releaseControl();
Also return from the function, owtherwise test.fail will be called as well. 

WebKit/chromium/ChangeLog:5
 +          [Chromium] Add a sanity test for heap profiler.
Can you implement it as a layout test instead?

[Mikhail Naganov]

Created attachment 59359 [details]
return added

Added a 'return'. But I must note, that I ran the tests, and it looks like after it reports success, reporting a failure just doesn't count.

It seems currently impossible to implement it as a layout test, because the panel is Chromium-only, and resides in chromium platform code.

[Mikhail Naganov]

Manually committed as http://trac.webkit.org/changeset/61613


    2010-06-21  Mikhail Naganov  <[e-mail]>
    
            Reviewed by Pavel Feldman.
    
            [Chromium] Add a sanity test for heap profiler.
    
            https://bugs.webkit.org/show_bug.cgi?id=40917
    
            * src/js/Tests.js:
            (.TestSuite.prototype.testHeapProfiler.findDisplayedNode):
            (.TestSuite.prototype.testHeapProfiler.findVisibleView):
            (.TestSuite.prototype.testHeapProfiler):