Bug 40913 - [Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.
Summary: [Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFronte...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
Depends on:
Reported: 2010-06-21 06:01 PDT by Mikhail Naganov
Modified: 2010-06-21 06:44 PDT (History)
3 users (show)

See Also:

patch (6.17 KB, patch)
2010-06-21 06:04 PDT, Mikhail Naganov
no flags Details | Formatted Diff | Diff
lift up DEPS (6.48 KB, patch)
2010-06-21 06:07 PDT, Mikhail Naganov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2010-06-21 06:01:38 PDT
Continuing our journey on making a non-static version of WebDevToolsAgentClient::sendMessageToFrontendOnIOThread. After removing usage, it will be possible to remove implementation from Chromium.
Comment 1 Mikhail Naganov 2010-06-21 06:04:11 PDT
Created attachment 59245 [details]
Comment 2 Mikhail Naganov 2010-06-21 06:07:00 PDT
Created attachment 59246 [details]
lift up DEPS
Comment 3 Yury Semikhatsky 2010-06-21 06:15:14 PDT
Comment on attachment 59246 [details]
lift up DEPS

 +  // FIXME: Remove after adding #include into devtools_agent_filter.cc
Please file a bug on this and add its number to the FIXME.
Comment 4 Mikhail Naganov 2010-06-21 06:44:51 PDT
Manually committed as http://trac.webkit.org/changeset/61539

    2010-06-21  Mikhail Naganov  <mnaganov@chromium.org>
            Reviewed by Yury Semikhatsky,
            [Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.
            Also, move WebDevToolsMessageTransport to its own header file.
            * DEPS:
            * WebKit.gyp:
            * public/WebDevToolsAgent.h:
            * public/WebDevToolsAgentClient.h:
            * public/WebDevToolsMessageTransport.h: Added.
            * src/WebDevToolsAgentImpl.cpp: