Bug 40910 - [Qt] Avoid unnecessary image conversion in RGBA32Buffer::zeroFill()
Summary: [Qt] Avoid unnecessary image conversion in RGBA32Buffer::zeroFill()
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Keywords: Performance, Qt, QtTriaged
Depends on:
Reported: 2010-06-21 05:14 PDT by Balazs Kelemen
Modified: 2011-04-19 05:15 PDT (History)
3 users (show)

See Also:

proposed patch (1.15 KB, patch)
2010-06-21 05:18 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2010-06-21 05:14:46 PDT
It is totally useless to converting the QImage for the QPixmap and then fill the pixmap with zero. Instead of this we can create an empty pixmap with the appropriate dimensions and fill that.
Comment 1 Balazs Kelemen 2010-06-21 05:18:49 PDT
Created attachment 59242 [details]
proposed patch
Comment 2 Benjamin Poulain 2010-06-21 05:49:54 PDT
You are right, I did an unfortunate copy-paste there.
Comment 3 WebKit Commit Bot 2010-06-21 07:08:48 PDT
Comment on attachment 59242 [details]
proposed patch

Clearing flags on attachment: 59242

Committed r61540: <http://trac.webkit.org/changeset/61540>
Comment 4 WebKit Commit Bot 2010-06-21 07:08:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2010-06-21 07:21:51 PDT
Revision r61540 cherry-picked into qtwebkit-2.0 with commit 45d1c9149ef8940081fa8dd35854d2b95ebaf3cd