RESOLVED FIXED Bug 40899
WebSocket and EventSource .URL should be .url 
https://bugs.webkit.org/show_bug.cgi?id=40899
Summary WebSocket and EventSource .URL should be .url
Simon Pieters (:zcorpan)
Reported 2010-06-20 20:33:38 PDT
You should rename .URL to .url on the WebSocket interface. http://html5.org/tools/web-apps-tracker?from=5064&to=5065 http://lists.w3.org/Archives/Public/public-webapps/2010AprJun/0563.html
Attachments
Patch (8.24 KB, patch)
2012-01-20 18:22 PST, Pablo Flouret 		no flags
DetailsFormatted DiffDiff
Fixed tests (8.24 KB, patch)
2012-01-21 15:41 PST, Pablo Flouret 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-06-22 12:00:48 PDT
I'm not sure if we want to drop support for .URL, it's been shipped already.
Alexey Proskuryakov
Comment 2 2010-06-22 15:38:54 PDT
I think that the spec should be changed back. Sent an e-mail to public-webapps to resume the discussion.
Pablo Flouret
Comment 3 2012-01-20 15:36:51 PST
Firefox and Opera are using .url for both EventSource and WebSocket, if not changed should .url be supported alongside .URL?
Alexey Proskuryakov
Comment 4 2012-01-20 15:52:34 PST
I'd say so, yes.
Pablo Flouret
Comment 5 2012-01-20 17:25:06 PST
I can make a patch. To clarify, i understood you prefer to add .url alongside .URL instead of changing it to lowercase directly, right?
Pablo Flouret
Comment 6 2012-01-20 18:22:39 PST
Created attachment 123423 [details] Patch
Adam Barth
Comment 7 2012-01-20 18:32:19 PST
Comment on attachment 123423 [details] Patch I take it we've failed to convince the spec to change.
WebKit Review Bot
Comment 8 2012-01-20 21:19:35 PST
Comment on attachment 123423 [details] Patch Rejecting attachment 123423 [details] from commit-queue. New failing tests: http/tests/websocket/tests/hybi/url-attribute.html http/tests/websocket/tests/hixie76/url-attribute.html Full output: http://queues.webkit.org/results/11297287
Adam Barth
Comment 9 2012-01-20 21:29:07 PST
I suspect those are progressions. @Pablo: Can you upload a new version of this patch with changes to the test results? (You can generate them using the --reset-results flag on run-webkit-tests.)
WebKit Review Bot
Comment 10 2012-01-20 21:36:52 PST
Comment on attachment 123423 [details] Patch Attachment 123423 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11311307 New failing tests: http/tests/websocket/tests/hybi/url-attribute.html http/tests/websocket/tests/hixie76/url-attribute.html
Pablo Flouret
Comment 11 2012-01-21 15:41:26 PST
Created attachment 123460 [details] Fixed tests Chromium normalized the urls to have a trailing slash.
WebKit Review Bot
Comment 12 2012-01-21 17:09:32 PST
Comment on attachment 123460 [details] Fixed tests Clearing flags on attachment: 123460 Committed r105580: <http://trac.webkit.org/changeset/105580>
WebKit Review Bot
Comment 13 2012-01-21 17:09:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.