Bug 40897 – Get rid of the extensionToMIME mapping in WebBasePluginPackage

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Get rid of the extensionToMIME mapping in WebBasePluginPackage

[Anders Carlsson]

Created attachment 59223 [details]
Patch

Comment on attachment 59223 [details]
Patch

> +    for (size_t i = 0; i < mimeTypes.size(); ++i) {
> +        const MimeClassInfo& mimeClassInfo = mimeTypes[i];
> +        
> +        for (size_t i = 0; i < mimeClassInfo.extensions.size(); ++i) {

Please don’t reuse the outer loop’s index variable.

> +- (NSString *)MIMETypeForExtension:(const String&)extension
>  {
> -    return [extensionToMIME objectForKey:extension];
> +    ASSERT(extension.lower() == extension);
> +    
> +    for (size_t i = 0; i < mimeTypes.size(); ++i) {
> +        const MimeClassInfo& mimeClassInfo = mimeTypes[i];
> +        
> +        for (size_t i = 0; i < mimeClassInfo.extensions.size(); ++i) {

Diito.

…
> +    return NO;

I doubt that clang++ would allow returning NO from an (NSString *) method. Please return nil.

[Anders Carlsson]

Committed r61523: <http://trac.webkit.org/changeset/61523>

[WebKit Review Bot]

http://trac.webkit.org/changeset/61523 might have broken SnowLeopard Intel Release (Tests)

[Adam Barth]

Looks like a real failure...

Tests that caused the DumpRenderTree tool to crash:

compositing/geometry/object-clip-rects-assertion.html	stderr
dom/html/level2/html/AppletsCollection.html	stderr
fast/dom/object-embed-plugin-scripting.html	stderr
plugins/embed-attributes-setting.html	expected