Bug 40894 - Move the NSBundle ivar to WebPluginPackage
Summary: Move the NSBundle ivar to WebPluginPackage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-20 14:50 PDT by Anders Carlsson
Modified: 2010-06-20 18:30 PDT (History)
0 users

See Also:


Attachments
Patch (9.15 KB, patch)
2010-06-20 14:52 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-06-20 14:50:37 PDT
Move the NSBundle ivar to WebPluginPackage
Comment 1 Anders Carlsson 2010-06-20 14:52:31 PDT
Created attachment 59217 [details]
Patch
Comment 2 mitz 2010-06-20 15:02:28 PDT
Comment on attachment 59217 [details]
Patch

> +    cfBundle = CFBundleCreate(NULL, (CFURLRef)[NSURL fileURLWithPath:path]);

Please change NULL to kCFAllocatorDefault.

> +    if (nsBundle == nil) {

Please change this to !nsBundle.
Comment 3 Anders Carlsson 2010-06-20 18:30:28 PDT
Committed r61519: <http://trac.webkit.org/changeset/61519>