Bug 40889 – Sheriffbot: Should allow "r" in SVN_REVISION

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Joseph Pecoraro]

Situation I just had:

  JoePeck:    sheriffbot: rollout r61506 Causes crash. Will take a different approach.
  sheriffbot: Preparing rollout for rr61506...
  sheriffbot: JoePeck: Failed to create rollout patch:
  sheriffbot: Invalid svn revision number "r61506".

=(. Bot could be more lenient.

[Joseph Pecoraro]

Created attachment 59209 [details]
Strip a Leading "r" if its there.

NOTE: I didn't run the tests! How do I run the python
tests for the irc bot?

[Joseph Pecoraro]

CC'ing a bunch of people who have worked in the WebKitTools/Scripts/webkitpy/tool
directory. The patch is simple enough, but see my question above about running the
tests for the tools. Thanks!

[Adam Barth]

You can run test-webkitpy

[Adam Barth]

Comment on attachment 59209 [details]
Strip a Leading "r" if its there.

Lgtm

[Joseph Pecoraro]

(In reply to comment #3)
> You can run test-webkitpy

Excellent, that worked perfectly!

Has it been considered that this be renamed to match the usual
run-*-tests pattern? I see there are a few like this, all for scripts:

  WebKitTools/Scripts/test-webkit-scripts
  WebKitTools/Scripts/test-webkitperl
  WebKitTools/Scripts/test-webkitpy

[Adam Barth]

You can look at the discussion on the bug where thoses were added.  I think various folks preferred the test-* pattern for reasons I don't remember.

[Joseph Pecoraro]

(In reply to comment #6)
> You can look at the discussion on the bug where thoses were added.
> I think various folks preferred the test-* pattern for reasons I don't
> remember.

Ahh, okay. Thanks!

[WebKit Commit Bot]

Comment on attachment 59209 [details]
Strip a Leading "r" if its there.

Clearing flags on attachment: 59209

Committed r61515: <http://trac.webkit.org/changeset/61515>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.