Bug 40882 - Add ability to have a WebProcess per WebContext
Summary: Add ability to have a WebProcess per WebContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-19 17:24 PDT by Sam Weinig
Modified: 2010-06-19 18:20 PDT (History)
2 users (show)

See Also:


Attachments
patch (34.79 KB, patch)
2010-06-19 17:28 PDT, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-06-19 17:24:18 PDT
Add ability to have a WebProcess per WebContext.
Comment 1 Sam Weinig 2010-06-19 17:28:35 PDT
Created attachment 59193 [details]
patch
Comment 2 WebKit Review Bot 2010-06-19 17:29:40 PDT
Attachment 59193 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/WebProcessManager.cpp:45:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
WebKit2/UIProcess/WebContext.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit2/UIProcess/WebProcessProxy.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2010-06-19 17:34:30 PDT
Comment on attachment 59193 [details]
patch

r=me!
Comment 4 Sam Weinig 2010-06-19 17:39:57 PDT
Landed in r61500.
Comment 5 Adam Barth 2010-06-19 18:06:11 PDT
Just curious, what's the testing plan for this sort of patch?
Comment 6 Sam Weinig 2010-06-19 18:20:11 PDT
(In reply to comment #5)
> Just curious, what's the testing plan for this sort of patch?

As with most API-esque patches, there is not much testing going on in this area right now.  I am working toward getting a DRT up and running and at some point plan on having a API testing harness, but that is still off a bit.